On Wed, Mar 08, 2023 at 10:55:31AM +0800, Baolu Lu wrote:
On 3/8/23 8:35 AM, Jason Gunthorpe wrote:
With the recent rework this no longer needs to be done at domain attachment time, we know if the device is usable by iommufd when we bind it.
The value of msi_device_has_isolated_msi() is not allowed to change while a driver is bound.
Reviewed-by: Kevin Tiankevin.tian@intel.com Signed-off-by: Jason Gunthorpejgg@nvidia.com
drivers/iommu/iommufd/device.c | 38 ++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c index c6f4852a8a0c08..63b65cdfe97f29 100644 --- a/drivers/iommu/iommufd/device.c +++ b/drivers/iommu/iommufd/device.c @@ -60,6 +60,26 @@ struct iommufd_device *iommufd_device_bind(struct iommufd_ctx *ictx, if (!group) return ERR_PTR(-ENODEV);
- /*
* For historical compat with VFIO the insecure interrupt path is* allowed if the module parameter is set. Insecure means that a MemWr* operation from the device (eg a simple DMA) cannot trigger anNit:
"... cannot trigger an ..." or "... can trigger an ..."?
Oh, yes that got flipped at some point
Thanks, Jason