Hi,
On 2023-09-11 at 09:59:31 -0700, Reinette Chatre wrote:
Hi Maciej,
On 9/1/2023 6:42 AM, Wieczor-Retman Maciej wrote:
resctrlfs.c file contains mostly functions that interact in some way
This can just be "resctrlfs.c contains ..." (no need for "file")
Right, sorry, I'll correct this and the one below.
with resctrl FS entries while functions inside resctrl_val.c deal with measurements and benchmarking.
run_benchmark() is located in resctrlfs.c file even though it's
same here
purpose is not interacting with the resctrl FS but to execute cache checking logic.
Move run_benchmark() to resctrl_val.c just before resctrl_val() that makes use of run_benchmark(). Make run_benchmark() static since it's not used between multiple files anymore.
Remove return comment from kernel-doc since the function is type void.
Signed-off-by: Wieczor-Retman Maciej maciej.wieczor-retman@intel.com Reviewed-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com
Reviewed-by: Reinette Chatre reinette.chatre@intel.com
Reinette
Thank you for the review!