On 01/12/20 4:36 pm, Andy Shevchenko wrote:
On Tue, Dec 1, 2020 at 9:21 AM Arpitha Raghunandan 98.arpi@gmail.com wrote:
Convert test lib/test_hexdump.c to KUnit. More information about KUnit can be found at: https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html. KUnit provides a common framework for unit tests in the kernel. KUnit and kselftest are standardizing around KTAP, converting this test to KUnit makes this test output in KTAP which we are trying to make the standard test result format for the kernel.
Below doesn't suit commit message, perhaps adding it after '---' line would be good. In the commit message you can choose one failed case followed by all OK and show the difference.
Okay, I will make this change.
I ran both the original and converted tests as is to produce the output for success of the test in the two cases. I also ran these tests with a small modification to show the difference in the output for failure of the test in both cases. The modification I made is: static const char * const test_data_4_le[] __initconst = {
"7bdb32be", "b293180a", "24c4ba70", "9b34837d",
"7bdb32be", "b293180a", "24c4ba70", "9b3483d",The difference in outputs can be seen here: https://gist.github.com/arpi-r/38f53a3c65692bf684a6bf3453884b6e
Looks pretty much good, what I'm sad to see is the absence of the test statistics. Any ideas if we can get it back?
I could again include variable total_tests as was in the original test. Would that be fine?
Thanks!