Re: [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'

On 5/7/21 8:56 PM, Jarkko Sakkinen wrote:

Rename symbols for better clarity:

• 'eenter' -> 'vdso_sgx_enter_enclave'
• 'sgx_call_vdso' -> 'sgx_enter_enclave'

Another sentence or two here would do wonders:

'eenter' might be confused for directly calling ENCLU[EENTER]. It does not. It calls into the VDSO, which actually has the EENTER instruction.

'sgx_call_vdso' is *only* used for entering the enclave. It's not some generic SGX call into the VDSO.

Make the naming reflect that.

Right?