Hello Jon,
On Tue, Aug 27, 2024 at 3:58 AM Jon Maloy jmaloy@redhat.com wrote:
On 2024-08-23 19:44, Jason Xing wrote:
Hello Jon,
On Sat, Aug 24, 2024 at 5:19 AM jmaloy@redhat.com wrote:
From: Jon Maloy jmaloy@redhat.com
We add a selftest to check that the new feature added in commit 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") works correctly.
Reviewed-by: Stefano Brivio sbrivio@redhat.com Tested-by: Stefano Brivio sbrivio@redhat.com Signed-off-by: Jon Maloy jmaloy@redhat.com
Thanks for working on this. Sorry that I just noticed I missed your previous reply :(
There is still the ditto UDP selftest to be done ;-)
The reason why I didn't respond at that time is because I was unsure if I had enough time to finish it. Now it's time.
After digging into this, there will be a lot of duplicated code if I write a new one named like "udp_so_peek_off". I think adjusting your tcp_so_peek_off.c to complete the UDP part is just fine. Of course, tcp_so_peek_off.c will be renamed :)
I will post one later to see if it's reasonable...
Thanks, Jason