On Wed, Jan 24, 2024 at 11:49:43AM +0800, David Gow wrote:
On Wed, 24 Jan 2024 at 00:31, Lucas De Marchi lucas.demarchi@intel.com wrote:
On Tue, Jan 23, 2024 at 04:01:49PM +0800, David Gow wrote:
On Tue, 23 Jan 2024 at 01:14, Lucas De Marchi lucas.demarchi@intel.com wrote:
By allowing the filter_glob parameter to be written to, it's possible to tweak the testsuites that will be executed on new module loads. This makes it easier to run specific tests without having to reload kunit and provides a way to filter tests on real HW even if kunit is builtin. Example for xe driver:
Run just 1 test # echo -n xe_bo > /sys/module/kunit/parameters/filter_glob # modprobe -r xe_live_test # modprobe xe_live_test # ls /sys/kernel/debug/kunit/ xe_bo
Run all tests # echo * > /sys/module/kunit/parameters/filter_glob # modprobe -r xe_live_test # modprobe xe_live_test # ls /sys/kernel/debug/kunit/ xe_bo xe_dma_buf xe_migrate xe_mocs
For completeness and to cover other use cases, also change filter and filter_action to rw.
Link: https://lore.kernel.org/intel-xe/dzacvbdditbneiu3e3fmstjmttcbne44yspumpkd6sj... Reviewed-by: Rae Moar rmoar@google.com Signed-off-by: Lucas De Marchi lucas.demarchi@intel.com
This looks good to me, and works here.
Reviewed-by: David Gow davidgow@google.com
are you going to merge this through kunit tree or should I carry it in drm ?
I think we'll merge it via KUnit for 6.9, but if you need it sooner, I doubt it'd cause problems if it went in via DRM instead.
I think it's fine to have it on your tree. For our CI, we can just apply it on the side to have it working before the 6.9 merge window.
thanks Lucas De Marchi