Re: [PATCH 0/2] selftests/harness: Handle timeouts cleanly

On Fri, Mar 13, 2020 at 11:25:58AM -0600, shuah wrote:

Hi Kees,

On 3/11/20 3:17 PM, Kees Cook wrote:

...

When a selftest would timeout before, the program would just fall over and no accounting of failures would be reported (i.e. it would result in an incomplete TAP report). Instead, add an explicit SIGALRM handler to cleanly catch and report the timeout.

Before:

     [==========] Running 2 tests from 2 test cases.
     [ RUN      ] timeout.finish
     [       OK ] timeout.finish
     [ RUN      ] timeout.too_long
     Alarm clock

After:

     [==========] Running 2 tests from 2 test cases.
     [ RUN      ] timeout.finish
     [       OK ] timeout.finish
     [ RUN      ] timeout.too_long
     timeout.too_long: Test terminated by timeout
     [     FAIL ] timeout.too_long
     [==========] 1 / 2 tests passed.
     [  FAILED  ]

This is good info. to capturein the commit logs for the patches.

The cover letter is an exact copy of patch 2's commit log. :)

Please add them and send v2. You can also fix the subject prefix at the same time :)

I'll resend a v2 with fixed prefix regardless.