On Tue, 8 Jul 2025 23:13:01 +0530 Suresh Chandrappa suresh.k.chandrappa@gmail.com wrote:
Hi Joshua,
Thanks for the feedback! In the first patch, both shmem and mmap operations are present, but I hadn’t introduced any logic to distinguish between them yet. That distinction is added in the second patch through a new API.
Hi Suresh,
Yes, this makes sense to me. I think what I was getting at was that we could still make a conditional statement like
if (type == FILE_SHMEM) ksft_print_msg("Unable to create shmem file.\n")' else if (type == FILE_MMAP) ksft_print_msg("Unable to create mmap file.\n");
(or use a switch statement)
...
And just refactor it in patch 2, as opposed to changing the behavior. But this is mostly a nit. If you are planning to merge both patches in one patch in the next version, then all of these comments shouldn't matter : -)
Looking forward to the next version, have a great day! Joshua
Sent using hkml (https://github.com/sjp38/hackermail)