Re: [PATCH 17/17] vsprintf: rework bitmap_list_string

On Thu, Aug 26, 2021 at 04:15:09PM +0200, Petr Mladek wrote:

On Sat 2021-08-14 14:17:13, Yury Norov wrote:

...

bitmap_list_string() is very ineffective when printing bitmaps with long ranges of set bits because it calls find_next_bit for each bit in the bitmap. We can do better by detecting ranges of set bits.

In my environment, before/after is 943008/31008 ns.

Signed-off-by: Yury Norov yury.norov@gmail.com Tested-by: Wolfram Sang wsa+renesas@sang-engineering.com

I like the patch. The new code is much easier to follow. Feel free to use:

Reviewed-by: Petr Mladek pmladek@suse.com

Best Regards, Petr

Thanks Petr! The patch is already in the linux-next.

Andrew, Stephen, can you please append Petr's reviewed-by?

Thanks, Yury