Re: [PATCH v2] kunit: run kunit_tool from any directory

On 2/19/20 3:38 PM, Heidi Fahim wrote:

On Wed, Feb 19, 2020 at 2:18 PM shuah <shuah@kernel.org mailto:shuah@kernel.org> wrote:

Hi Heidi,

On 2/18/20 3:19 PM, Heidi Fahim wrote:
 > Implemented small fix so that the script changes work directories
to the
 > root of the linux kernel source tree from which kunit.py is run. This
 > enables the user to run kunit from any working directory. Originally
 > considered using os.path.join but this is more error prone as we
would
 > have to find all file path usages and modify them accordingly. Using
 > os.chdir ensures that the entire script is run within /linux.
 >
 > Signed-off-by: Heidi Fahim <heidifahim@google.com
<mailto:heidifahim@google.com>>
 > Reviewed-by: Brendan Higgins <brendanhiggins@google.com
<mailto:brendanhiggins@google.com>>

Thanks for  the patch. In the future please include changes from v1
to v2.

I am assuming this v2 addresses Frank's comments.

Sorry about that! Yes the only change here was in the commit message addressing Frank's comment.

Great. I will pull this in for 5.6-rc4.

thanks, -- Shuah