On Tue, Apr 26, 2022 at 6:00 PM Axel Rasmussen axelrasmussen@google.com wrote:
You're right, [1] says _IO is appropriate for ioctls which only take an integer argument. I'll send a v3 with this fix, although I might wait a bit for any other review comments before doing so. Thanks for taking a look!
If there are no other command codes, you could also set .compat_ioctl to the same function pointer as .unlocked_ioctl, the compat_ptr_ioctl conversion is only needed when there are commands that take a pointer.
Armd