On Thu, Jan 27, 2022 at 11:36 AM David Gow davidgow@google.com wrote:
On Wed, Jan 26, 2022 at 5:00 AM Daniel Latypov dlatypov@google.com wrote:
We currently have 2 other versions of KUNIT_INIT_BINARY_ASSERT_STRUCT. The only differences are that
- the format funcition they pass is different
Minor nit: s/funcition/function/
- the types of left_val/right_val should be different (integral,
pointer, string).
The latter doesn't actually matter since these macros are just plumbing them along to KUNIT_ASSERTION where they will get type checked.
So combine them all into a single KUNIT_INIT_BINARY_ASSERT_STRUCT that now also takes the format function as a parameter.
Signed-off-by: Daniel Latypov dlatypov@google.com
Makes sense to me.
One minor spelling nit: probably not worth a whole new version over, but if v2 ever happens, worth fixing at the same time...
Oops, forgot to add the Reviewed-by!
Reviewed-by: David Gow davidgow@google.com
-- David