On 11/17/22 16:33, Peter Xu wrote:
On Wed, Nov 16, 2022 at 08:09:11PM -0400, Joel Savitz wrote:
However, I noticed that on the mm-everything branch, the hugepage-mmap test fails:
# ./run_vmtests.sh -t "hugetlb" running: ./hugepage-mmap
running ./hugepage-mmap
Open failed: No such file or directory [FAIL] ...
It appears this is due to commit 0796c7b8be84 ("selftests/vm: drop mnt point for hugetlb in run_vmtests.sh") as the test still replies on the ./huge mountpoint removed in that commit. The test passes before that patchset is applied.
Oops, sorry I totally overlooked this hard-coded test case using the mntpoint.
Fix is simple though, which is attached.
-- Peter Xu
From 71da2480d4bac0fc598e4d1f05f71aba8b980bc4 Mon Sep 17 00:00:00 2001 From: Peter Xu peterx@redhat.com Date: Thu, 17 Nov 2022 16:29:15 -0500 Subject: [PATCH] selftests/vm: use memfd for hugepage-mmap test Content-type: text/plain
This test was overlooked with a hard-coded mntpoint path in test when we're removing the hugetlb mntpoint in commit 0796c7b8be84. Fix it up so the test can keep running.
Reported-by: Joel Savitz jsavitz@redhat.com Signed-off-by: Peter Xu peterx@redhat.com
tools/testing/selftests/vm/hugepage-mmap.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
Thanks Peter! That is also something I noticed and was on my todo list.
Acked-by: Mike Kravetz mike.kravetz@oracle.com