On Fri, 25 Jul 2025 09:47:48 -0700 David Matlack dmatlack@google.com wrote:
On Fri, Jun 20, 2025 at 4:21 PM David Matlack dmatlack@google.com wrote:
This series introduces VFIO selftests, located in tools/testing/selftests/vfio/.
Hi Alex,
I wanted to discuss how you would like to proceed with this series.
The series is quite large, so one thing I was wondering is if you think it should be split up into separate series to make it easier to review and merge. Something like this:
- Patches 01-08 + 30 (VFIO selftests library, some basic tests, and run script)
- Patches 09-22 (driver framework)
- Patches 23-28 (iommufd support)
- Patches 31-33 (integration with KVM selftests)
I also was curious about your thoughts on maintenance of VFIO selftests, since I don't think we discussed that in the RFC. I am happy to help maintain VFIO selftests in whatever way makes the most sense. For now I added tools/testing/selftests/vfio under the top-level VFIO section in MAINTAINERS (so you would be the maintainer) and then also added a separate section for VFIO selftests with myself as a Reviewer (see PATCH 01). Reviewer felt like a better choice than Maintainer for myself since I am new to VFIO upstream (I've primarily worked on KVM in the past).
Hi David,
There's a lot of potential here and I'd like to see it proceed. I've got various unit tests that we could incorporate over time and obviously picking up Aaron's latency would be useful as well.
Something that we should continue to try to improve is the automation. These tests are often targeting a specific feature, so matching a device to a unit test becomes a barrier to automated runs. I wonder if we might be able to reach a point where the test runner can select appropriate devices from a pool of devices specified via environment variables.
An incremental approach like you're suggesting is usually the best course. Implement the framework and something basic, then build on it. 30+ patches is a bit much to chew on initially.
Your recommendation for MAINTAINERS sounds good to me. I'm not too familiar with the selftests, so I'll clearly be looking for your input once we've established the initial code. Thanks,
Alex