Re: [PATCH] selftests: drivers: net: fix name not defined

On Wed, 9 Oct 2024 00:01:33 +0200 Alessandro Zanni wrote:

This fix solves this error, when calling kselftest with targets "drivers/net":

File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ if e.errno == errno.ENOSPC: NameError: name 'errno' is not defined

The module errno makes available standard error system symbols.

Can you say more about how you hit this error?

If it's just based on static analysis please mention that in the commit message, and also mention that the problem doesn't happen in practice. This will avoid the patch being backported unnecessarily.

We run all the tests in our CI, and the problem is not hit. But I agree with you that the import is theoretically missing.