22 Jul
2022
22 Jul
'22
12:54 a.m.
On Thu, Jul 21, 2022 at 1:26 AM 'Sadiya Kazi' via KUnit Development kunit-dev@googlegroups.com wrote:
Run_wrapper.rst was missing some command line arguments. Added additional args in the file.
Signed-off-by: Sadiya Kazi sadiyakazi@google.com
Reviewed-by: Daniel Latypov dlatypov@google.com
Looks good! A minor suggestion down below to go along with what everyone else has said.
+- ``--qemu_config``: Specifies the path to a file containing a
- custom qemu architecture definition. This should be a python file
- containing a `QemuArchParams` object.
+- ``--qemu_args``: Specifies additional QEMU arguments, for example, "-smp 8".
Minor nit: I think ``-smp 8`` would be a bit better here. It feels like it would fit what we did with other example arguments.