25 Oct
2024
25 Oct
'24
4:14 p.m.
On Fri, Oct 25, 2024 at 09:04:15AM +0000, Tian, Kevin wrote:
From: Nicolin Chen nicolinc@nvidia.com Sent: Tuesday, October 22, 2024 8:19 AM
+static struct iommufd_hwpt_nested * +iommufd_hwpt_nested_alloc_for_viommu(struct iommufd_viommu *viommu,
const struct iommu_user_data *user_data)probably "_for" can be skipped to reduce the name length
That would sound like a hwpt_nested allocating vIOMMU...
It'd be probably neutral to have iommufd_viommu_alloc_hwpt_nested, yet we have iommufd_hwpt_nested_alloc (HWPT-based) to align with..
looks there missed a check on flags in this path.
Oh yes, I missed that. Will pass in the cmd->flags.
Thanks Nicolin