Re: [PATCH bpf-next 02/10] selftests/bpf: test_tunnel: Add ping helpers

On 02/27, Bastien Curutchet (eBPF Foundation) wrote:

All tests use more or less the same ping commands as final validation. Also test_ping()'s return value is checked with ASSERT_OK() while this check is already done by the SYS() macro inside test_ping().

Create helpers around test_ping() and use them in the tests to avoid code duplication. Remove the unnecessary ASSERT_OK() from the tests.

Signed-off-by: Bastien Curutchet (eBPF Foundation) bastien.curutchet@bootlin.com

Acked-by: Stanislav Fomichev sdf@fomichev.me