Hi Dmitry,
First, thank you for submitting this very helpful set of tcp-ao selftests!
-----Original Message----- From: Dmitry Safonov dima@arista.com Sent: Thursday, December 14, 2023 9:36 PM To: Shuah Khan shuah@kernel.org; David Ahern dsahern@kernel.org; David S. Miller davem@davemloft.net; Eric Dumazet edumazet@google.com; Jakub Kicinski kuba@kernel.org; Paolo Abeni pabeni@redhat.com Cc: Dmitry Safonov dima@arista.com; Salam Noureddine noureddine@arista.com; Bob Gilligan gilligan@arista.com; linux- kernel@vger.kernel.org; linux-kselftest@vger.kernel.org; netdev@vger.kernel.org; Dmitry Safonov 0x7f454c46@gmail.com Subject: [PATCH 01/12] selftests/net: Add TCP-AO library
Provide functions to create selftests dedicated to TCP-AO. They can run in parallel, as they use temporary net namespaces. They can be very specific to the feature being tested. This will allow to create a lot of TCP-AO tests, without complicating one binary with many --options and to create scenarios, that are hard to put in bash script that uses one binary.
Signed-off-by: Dmitry Safonov dima@arista.com
- key_dump[0].nkeys = nr_keys;
- key_dump[0].get_all = 1;
- key_dump[0].get_all = 1;
Duplicate assignment of get_all.
- err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS,
key_dump, &key_dump_sz);- if (err) {
free(key_dump);return -errno;- }
+}
+const struct sockaddr_in6 addr_any6 = {
- .sin6_family = AF_INET6,
+};
+const struct sockaddr_in addr_any4 = {
- .sin_family = AF_INET,
+};
-- 2.43.0
Mohammad