On 3/13/23 5:11 PM, Liu, Jingqi wrote:
>> +struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *s2_domain,
>> + const void *user_data)
>> +{
>> + const struct iommu_hwpt_intel_vtd *vtd = user_data;
>> + struct dmar_domain *domain;
>> +
>
> Would it be better to add the following check ?
>
> if (WARN_ON(!user_data))
> return NULL;
The iommufd has already done the sanity check. Considering that this
callback is only for iommufd purpose, the individual driver has no need
to check it.
Best regards,
baolu
kselftest: rtc built with clang-16 getting failed but passed with gcc-12
build. Please find more details about test logs on clang-16 and gcc-12
and steps to reproduce locally on your machine by using tuxrun.
On the qemu-x86-64 clang builds it is intermittent failure;
you could notice that from the test history link below.
Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
Test log:
----------
Linux version 6.3.0-rc1-next-20230307 (tuxmake@tuxmake) (Debian clang
version 16.0.0 (++20230228093516+60692a66ced6-1~exp1~20230228093525.41),
Debian LLD 16.0.0) #1 SMP PREEMPT @1678159722
...
kselftest: Running tests in rtc
TAP version 13
1..1
# selftests: rtc: rtctest
# TAP version 13
# 1..8
# # Starting 8 tests from 1 test cases.
# # RUN rtc.date_read ...
# # rtctest.c:54:date_read:Current RTC date/time is 07/03/2023 03:55:04.
# # OK rtc.date_read
# ok 1 rtc.date_read
# # RUN rtc.date_read_loop ...
# # rtctest.c:96:date_read_loop:Continuously reading RTC time for 30s
(with 11ms breaks after every read).
# # rtctest.c:122:date_read_loop:Performed 2630 RTC time reads.
# # OK rtc.date_read_loop
# ok 2 rtc.date_read_loop
# # RUN rtc.uie_read ...
# # OK rtc.uie_read
# ok 3 rtc.uie_read
# # RUN rtc.uie_select ...
# # OK rtc.uie_select
# ok 4 rtc.uie_select
# # RUN rtc.alarm_alm_set ...
# # rtctest.c:222:alarm_alm_set:Alarm time now set to 03:55:44.
# # rtctest.c:241:alarm_alm_set:data: 1a0
# # OK rtc.alarm_alm_set
# ok 5 rtc.alarm_alm_set
# # RUN rtc.alarm_wkalm_set ...
# # rtctest.c:284:alarm_wkalm_set:Alarm time now set to 07/03/2023 03:55:47.
# # rtctest.c:290:alarm_wkalm_set:Expected -1 (-1) != rc (-1)
# # alarm_wkalm_set: Test terminated by assertion
# # FAIL rtc.alarm_wkalm_set
# not ok 6 rtc.alarm_wkalm_set
# # RUN rtc.alarm_alm_set_minute ...
# # rtctest.c:332:alarm_alm_set_minute:Alarm time now set to 03:56:00.
# # rtctest.c:351:alarm_alm_set_minute:data: 1a0
# # OK rtc.alarm_alm_set_minute
# ok 7 rtc.alarm_alm_set_minute
# # RUN rtc.alarm_wkalm_set_minute ...
# # rtctest.c:394:alarm_wkalm_set_minute:Alarm time now set to
07/03/2023 03:57:00.
# # rtctest.c:400:alarm_wkalm_set_minute:Expected -1 (-1) != rc (-1)
# # alarm_wkalm_set_minute: Test terminated by assertion
# # FAIL rtc.alarm_wkalm_set_minute
# not ok 8 rtc.alarm_wkalm_set_minute
# # FAILED: 6 / 8 tests passed.
# # Totals: pass:6 fail:2 xfail:0 xpass:0 skip:0 error:0
Links,
qemu-x86_64:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230306/te…
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230306/te…
qemu-arm64:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230307/te…
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230307/te…
Test history:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230307/te…
Test log:
---------
Linux version 6.3.0-rc1-next-20230307 (tuxmake@tuxmake)
(aarch64-linux-gnu-gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils
for Debian) 2.40) #1 SMP PREEMPT @1678159736
...
kselftest: Running tests in rtc
TAP version 13
1..1
# selftests: rtc: rtctest
# TAP version 13
# 1..8
# # Starting 8 tests from 1 test cases.
# # RUN rtc.date_read ...
# # rtctest.c:52:date_read:Current RTC date/time is 07/03/2023 03:48:22.
# # OK rtc.date_read
# ok 1 rtc.date_read
# # RUN rtc.date_read_loop ...
# # rtctest.c:95:date_read_loop:Continuously reading RTC time for 30s
(with 11ms breaks after every read).
# # rtctest.c:122:date_read_loop:Performed 2670 RTC time reads.
# # OK rtc.date_read_loop
# ok 2 rtc.date_read_loop
# # RUN rtc.uie_read ...
# # OK rtc.uie_read
# ok 3 rtc.uie_read
# # RUN rtc.uie_select ...
# # OK rtc.uie_select
# ok 4 rtc.uie_select
# # RUN rtc.alarm_alm_set ...
# # rtctest.c:221:alarm_alm_set:Alarm time now set to 03:49:02.
# # rtctest.c:241:alarm_alm_set:data: 1a0
# # OK rtc.alarm_alm_set
# ok 5 rtc.alarm_alm_set
# # RUN rtc.alarm_wkalm_set ...
# # rtctest.c:281:alarm_wkalm_set:Alarm time now set to 07/03/2023 03:49:05.
# # OK rtc.alarm_wkalm_set
# ok 6 rtc.alarm_wkalm_set
# # RUN rtc.alarm_alm_set_minute ...
# # rtctest.c:331:alarm_alm_set_minute:Alarm time now set to 03:50:00.
<47>[ 106.383091] systemd-journald[98]: Sent WATCHDOG=1 notification.
# # rtctest.c:351:alarm_alm_set_minute:data: 1a0
# # OK rtc.alarm_alm_set_minute
# ok 7 rtc.alarm_alm_set_minute
# # RUN rtc.alarm_wkalm_set_minute ...
# # rtctest.c:391:alarm_wkalm_set_minute:Alarm time now set to
07/03/2023 03:51:00.
# # OK rtc.alarm_wkalm_set_minute
# ok 8 rtc.alarm_wkalm_set_minute
# # PASSED: 8 / 8 tests passed.
# # Totals: pass:8 fail:0 xfail:0 xpass:0 skip:0 error:0
ok 1 selftests: rtc: rtctest
Links,
qemu-x86_64:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230307/te…
qemu-arm64:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230307/te…
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230307/te…
Steps to reproduce:
--------------
# To install tuxrun on your system globally:
# sudo pip3 install -U tuxrun==0.37.2
#
# See https://tuxrun.org/ for complete documentation.
tuxrun \
--runtime podman \
--device qemu-x86_64 \
--boot-args rw \
--kernel https://storage.tuxsuite.com/public/linaro/lkft/builds/2McWP6obiL1x51zgkgLX…
\
--modules https://storage.tuxsuite.com/public/linaro/lkft/builds/2McWP6obiL1x51zgkgLX…
\
--rootfs https://storage.tuxboot.com/debian/bookworm/amd64/rootfs.ext4.xz \
--parameters SKIPFILE=skipfile-lkft.yaml \
--parameters KSELFTEST=https://storage.tuxsuite.com/public/linaro/lkft/builds/2McWP6obiL…
\
--image docker.io/lavasoftware/lava-dispatcher:2023.01.0020.gc1598238f \
--tests kselftest-rtc \
--timeouts boot=15
--
Linaro LKFT
https://lkft.linaro.org
This patch series adds unit tests for the clk fixed rate basic type and
the clk registration functions that use struct clk_parent_data. To get
there, we add support for loading a DTB into the UML kernel that's
running the unit tests along with probing platform drivers to bind to
device nodes specified in DT.
With this series, we're able to exercise some of the code in the common
clk framework that uses devicetree lookups to find parents and the fixed
rate clk code that scans devicetree directly and creates clks. Please
review.
I Cced everyone to all the patches so they get the full context. I'm
hoping I can take the whole pile through the clk tree as they almost all
depend on each other. In the future I imagine it will be easy to add
more test nodes to the clk.dtsi file and not need to go across various
maintainer trees like this series does.
Stephen Boyd (8):
dt-bindings: Add linux,kunit binding
of: Enable DTB loading on UML for KUnit tests
kunit: Add test managed platform_device/driver APIs
clk: Add test managed clk provider/consumer APIs
dt-bindings: kunit: Add fixed rate clk consumer test
clk: Add KUnit tests for clk fixed rate basic type
dt-bindings: clk: Add KUnit clk_parent_data test
clk: Add KUnit tests for clks registered with struct clk_parent_data
.../clock/linux,clk-kunit-parent-data.yaml | 47 ++
.../kunit/linux,clk-kunit-fixed-rate.yaml | 35 ++
.../bindings/kunit/linux,kunit.yaml | 24 +
arch/um/kernel/dtb.c | 29 +-
drivers/clk/.kunitconfig | 3 +
drivers/clk/Kconfig | 7 +
drivers/clk/Makefile | 6 +
drivers/clk/clk-fixed-rate_test.c | 296 ++++++++++++
drivers/clk/clk-kunit.c | 204 ++++++++
drivers/clk/clk-kunit.h | 28 ++
drivers/clk/clk_test.c | 456 +++++++++++++++++-
drivers/of/Kconfig | 26 +
drivers/of/Makefile | 1 +
drivers/of/kunit/.kunitconfig | 4 +
drivers/of/kunit/Makefile | 4 +
drivers/of/kunit/clk.dtsi | 30 ++
drivers/of/kunit/kunit.dtsi | 9 +
drivers/of/kunit/kunit.dtso | 4 +
drivers/of/kunit/uml_dtb_test.c | 55 +++
include/kunit/platform_driver.h | 15 +
lib/kunit/Makefile | 6 +
lib/kunit/platform_driver-test.c | 107 ++++
lib/kunit/platform_driver.c | 207 ++++++++
23 files changed, 1599 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/linux,clk-kunit-parent-data.yaml
create mode 100644 Documentation/devicetree/bindings/kunit/linux,clk-kunit-fixed-rate.yaml
create mode 100644 Documentation/devicetree/bindings/kunit/linux,kunit.yaml
create mode 100644 drivers/clk/clk-fixed-rate_test.c
create mode 100644 drivers/clk/clk-kunit.c
create mode 100644 drivers/clk/clk-kunit.h
create mode 100644 drivers/of/kunit/.kunitconfig
create mode 100644 drivers/of/kunit/Makefile
create mode 100644 drivers/of/kunit/clk.dtsi
create mode 100644 drivers/of/kunit/kunit.dtsi
create mode 100644 drivers/of/kunit/kunit.dtso
create mode 100644 drivers/of/kunit/uml_dtb_test.c
create mode 100644 include/kunit/platform_driver.h
create mode 100644 lib/kunit/platform_driver-test.c
create mode 100644 lib/kunit/platform_driver.c
base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Dzień dobry,
Jesteśmy firmą z wieloletnim doświadczeniem, która sprawnie przygotuje dla Państwa ofertę i wszelkie formalności. Sam montaż zaplanujemy na wiosnę.
O samych plusach fotowoltaiki czy pompach ciepła na pewno już Państwo słyszeli, dlatego teraz prosimy o zostawienie kontaktu, aby nasz specjalista mógł przedstawić ofertę zgodną z Waszymi potrzebami.
Kiedy moglibyśmy z Państwem umówić się na rozmowę w celu zbadania potrzeb?
Pozdrawiam,
Piotr Werner
Patch 1 fixes a possible deadlock in subflow_error_report() reported by
lockdep. The report was in fact a false positive but the modification
makes sense and silences lockdep to allow syzkaller to find real issues.
The regression has been introduced in v5.12.
Patch 2 is a refactoring needed to be able to fix the two next issues.
It improves the situation and can be backported up to v6.0.
Patches 3 and 4 fix UaF reported by KASAN. It fixes issues potentially
visible since v5.7 and v5.19 but only reproducible until recently
(v6.0). These two patches depend on patch 2/7.
Patch 5 fixes the order of the printed values: expected vs seen values.
The regression has been introduced recently: v6.3-rc1.
Patch 6 adds missing ro_after_init flags. A previous patch added them
for other functions but these two have been missed. This previous patch
has been backported to stable versions (up to v5.12) so probably better
to do the same here.
Patch 7 fixes tcp_set_state() being called twice in a row since v5.10.
Patch 8 fixes another lockdep false positive issue but this time in
MPTCP PM code. Same here, some modifications in the code has been made
to silence this issue and help finding real ones later. This issue can
be seen since v6.2.
Note that checkpatch.pl is now complaining about the "Closes" tag but
discussions are ongoing to add an exception:
https://lore.kernel.org/all/a27480c5-c3d4-b302-285e-323df0349b8f@tessares.n…
Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
Changes in v2:
- Patches 3 and 4 have been modified to fix the issue reported on netdev
- Patch 8 has been added
- Rebased
- Link to v1: https://lore.kernel.org/r/20230227-upstream-net-20230227-mptcp-fixes-v1-0-0…
---
Geliang Tang (1):
mptcp: add ro_after_init for tcp{,v6}_prot_override
Matthieu Baerts (2):
selftests: mptcp: userspace pm: fix printed values
mptcp: avoid setting TCP_CLOSE state twice
Paolo Abeni (5):
mptcp: fix possible deadlock in subflow_error_report
mptcp: refactor passive socket initialization
mptcp: use the workqueue to destroy unaccepted sockets
mptcp: fix UaF in listener shutdown
mptcp: fix lockdep false positive in mptcp_pm_nl_create_listen_socket()
net/mptcp/pm_netlink.c | 16 +++
net/mptcp/protocol.c | 64 +++++------
net/mptcp/protocol.h | 6 +-
net/mptcp/subflow.c | 128 +++++++---------------
tools/testing/selftests/net/mptcp/userspace_pm.sh | 2 +-
5 files changed, 95 insertions(+), 121 deletions(-)
---
base-commit: 67eeadf2f95326f6344adacb70c880bf2ccff57b
change-id: 20230227-upstream-net-20230227-mptcp-fixes-cc78f3a2f5b2
Best regards,
--
Matthieu Baerts <matthieu.baerts(a)tessares.net>