October 2022 - Linux-kselftest-mirror

kselftest/next build: 7 builds: 0 failed, 7 passed, 2 errors (v6.1-rc1-1-gde3ee3f63400a)

by kernelci.org bot

kselftest/next build: 7 builds: 0 failed, 7 passed, 2 errors (v6.1-rc1-1-gde3ee3f63400a) Full Build Summary: https://kernelci.org/build/kselftest/branch/next/kernel/v6.1-rc1-1-gde3ee3f… Tree: kselftest Branch: next Git Describe: v6.1-rc1-1-gde3ee3f63400a Git Commit: de3ee3f63400a23954e7c1ad1cb8c20f29ab6fe3 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git Built: 4 unique architectures Errors Detected: arm64: defconfig+kselftest+arm64-chromebook (clang-15): 1 error arm: i386: x86_64: x86_64_defconfig+kselftest (clang-15): 1 error Errors summary: 2 error: write on a pipe with no reader ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- defconfig+kselftest (arm64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- defconfig+kselftest+arm64-chromebook (arm64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- defconfig+kselftest+arm64-chromebook (arm64, clang-15) — PASS, 1 error, 0 warnings, 0 section mismatches Errors: error: write on a pipe with no reader -------------------------------------------------------------------------------- i386_defconfig+kselftest (i386, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- multi_v7_defconfig+kselftest (arm, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- x86_64_defconfig+kselftest (x86_64, gcc-10) — PASS, 0 errors, 0 warnings, 0 section mismatches -------------------------------------------------------------------------------- x86_64_defconfig+kselftest (x86_64, clang-15) — PASS, 1 error, 0 warnings, 0 section mismatches Errors: error: write on a pipe with no reader --- For more info write to <info(a)kernelci.org>

2 years, 2 months

1
0
0 0

[PATCH v1] selftests: Use optional USERCFLAGS and USERLDFLAGS

by Mickaël Salaün

This change enables to extend CFLAGS and LDFLAGS from command line, e.g. to extend compiler checks: make USERCFLAGS=-Werror USERLDFLAGS=-static USERCFLAGS and USERLDFLAGS are documented in Documentation/kbuild/makefiles.rst and Documentation/kbuild/kbuild.rst This should be backported (down to 5.10) to improve previous kernel versions testing as well. Cc: Shuah Khan <skhan(a)linuxfoundation.org> Cc: stable(a)vger.kernel.org Signed-off-by: Mickaël Salaün <mic(a)digikod.net> Link: https://lore.kernel.org/r/20220909103901.1503436-1-mic@digikod.net --- tools/testing/selftests/lib.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index d44c72b3abe3..da47a0257165 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -119,6 +119,11 @@ endef clean: $(CLEAN) +# Enables to extend CFLAGS and LDFLAGS from command line, e.g. +# make USERCFLAGS=-Werror USERLDFLAGS=-static +CFLAGS += $(USERCFLAGS) +LDFLAGS += $(USERLDFLAGS) + # When make O= with kselftest target from main level # the following aren't defined. # base-commit: 7e18e42e4b280c85b76967a9106a13ca61c16179 -- 2.37.2

2 years, 2 months

2
2
0 0

selftests: net: pmtu.sh: Unable to handle kernel paging request at virtual address 2c86c000

by Naresh Kamboju

Following kernel crash reported while running selftests: net: pmtu.sh on x15 device with kselftests merge configs enabled. Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> # selftests: net: pmtu.sh ... # TEST: IPv4 over vxlan6: PMTU exceptions [ OK ] [ 169.299682] 8<--- cut here --- [ 169.302764] Unable to handle kernel paging request at virtual address 2c86c000 [ 169.310089] [2c86c000] *pgd=00000000 [ 169.313720] Internal error: Oops: 5 [#1] SMP ARM [ 169.318359] Modules linked in: act_csum act_pedit cls_flower sch_prio ip_tables x_tables veth tun cfg80211 bluetooth snd_soc_simple_card snd_soc_simple_card_utils etnaviv gpu_sched onboard_usb_hub snd_soc_davinci_mcasp snd_soc_ti_udma snd_soc_ti_edma snd_soc_ti_sdma snd_soc_core ac97_bus snd_pcm_dmaengine snd_pcm snd_timer snd soundcore display_connector fuse [last unloaded: test_blackhole_dev] [ 169.353576] CPU: 0 PID: 295 Comm: rngd Not tainted 6.0.3-rc1 #1 [ 169.359527] Hardware name: Generic DRA74X (Flattened Device Tree) [ 169.365631] PC is at percpu_counter_add_batch+0x28/0xc4 [ 169.370910] LR is at 0x0 [ 169.373443] pc : [<c0989aa8>] lr : [<00000000>] psr: 600d0113 [ 169.379730] sp : f0001ed8 ip : 00000020 fp : f0001f50 [ 169.385009] r10: c23aef04 r9 : c231efd0 r8 : c25da080 [ 169.390258] r7 : c84adb80 r6 : 00000001 r5 : c9a99440 r4 : 2c86c000 [ 169.396820] r3 : ffffffff r2 : ffffffff r1 : 00000000 r0 : c9a99440 [ 169.403381] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 169.410552] Control: 10c5387d Table: 891f006a DAC: 00000051 [ 169.416320] Register r0 information: slab net_namespace start c9a98ec0 data offset 64 pointer offset 1344 allocated at copy_net_ns+0x78/0x27c [ 169.429107] kmem_cache_alloc+0x328/0x43c [ 169.433380] copy_net_ns+0x78/0x27c [ 169.437164] create_new_namespaces+0x10c/0x2a4 [ 169.441894] unshare_nsproxy_namespaces+0x70/0x8c [ 169.446868] ksys_unshare+0x16c/0x32c [ 169.450836] ret_fast_syscall+0x0/0x1c [ 169.454864] Free path: [ 169.457305] cleanup_net+0x2e0/0x3c4 [ 169.461151] process_one_work+0x26c/0x708 [ 169.465454] worker_thread+0x60/0x4e8 [ 169.469421] kthread+0xfc/0x11c [ 169.472839] ret_from_fork+0x14/0x2c [ 169.476684] Register r1 information: NULL pointer [ 169.481414] Register r2 information: non-paged memory [ 169.486480] Register r3 information: non-paged memory [ 169.491577] Register r4 information: non-paged memory [ 169.496643] Register r5 information: slab net_namespace start c9a98ec0 data offset 64 pointer offset 1344 allocated at copy_net_ns+0x78/0x27c [ 169.509460] kmem_cache_alloc+0x328/0x43c [ 169.513763] copy_net_ns+0x78/0x27c [ 169.517517] create_new_namespaces+0x10c/0x2a4 [ 169.522247] unshare_nsproxy_namespaces+0x70/0x8c [ 169.527221] ksys_unshare+0x16c/0x32c [ 169.531188] ret_fast_syscall+0x0/0x1c [ 169.535217] Free path: [ 169.537658] cleanup_net+0x2e0/0x3c4 [ 169.541503] process_one_work+0x26c/0x708 [ 169.545806] worker_thread+0x60/0x4e8 [ 169.549743] kthread+0xfc/0x11c [ 169.553161] ret_from_fork+0x14/0x2c [ 169.557037] Register r6 information: non-paged memory [ 169.562103] Register r7 information: slab task_struct start c84adb40 data offset 64 pointer offset 0 allocated at copy_process+0x1a4/0x1950 [ 169.574707] kmem_cache_alloc+0x328/0x43c [ 169.579010] copy_process+0x1a4/0x1950 [ 169.583038] kernel_clone+0x5c/0x418 [ 169.586883] sys_clone+0x74/0x90 [ 169.590393] __sys_trace_return+0x0/0x10 [ 169.594604] Free path: [ 169.597076] rcu_core+0x3c8/0x1140 [ 169.600738] __do_softirq+0x130/0x538 [ 169.604675] Register r8 information: non-slab/vmalloc memory [ 169.610382] Register r9 information: non-slab/vmalloc memory [ 169.616058] Register r10 information: non-slab/vmalloc memory [ 169.621856] Register r11 information: 2-page vmalloc region starting at 0xf0000000 allocated at start_kernel+0x578/0x764 [ 169.632781] Register r12 information: non-paged memory [ 169.637939] Process rngd (pid: 295, stack limit = 0xf0188000) [ 169.643707] Stack: (0xf0001ed8 to 0xf0002000) [ 169.648101] 1ec0: c9b33540 00000000 [ 169.656311] 1ee0: 00000001 00000000 c25da080 c231efd0 c23aef04 c1325f00 00000020 c25da080 [ 169.664550] 1f00: c231efd0 c84adb80 c9b33570 c0402628 00000000 00000000 c04025c4 00000000 [ 169.672760] 1f20: 00000000 0000000a 00000000 c23b0940 c25d9e80 eeb0ff14 c229a5d8 c229a5d8 [ 169.680969] 1f40: c229a484 c229a484 eeb0fec0 00000001 00000000 f0001f50 00000000 e2868d57 [ 169.689178] 1f60: 00000002 c23030a4 00000008 00000009 c25d97e0 c231efd0 00000100 c84adb80 [ 169.697418] 1f80: 00000080 c0301e10 c3212340 c1770a48 00000015 c2303080 c229a518 0000000a [ 169.705627] 1fa0: c22a3100 c25d79bc c22a3100 ffffccf2 c2305d40 c1de927c c1dfc684 f0001fd0 [ 169.713836] 1fc0: 00400040 00000001 c231fbb0 c84adb80 000d0030 ffffffff c84adb80 c229a044 [ 169.722076] 1fe0: 00000000 b633f000 f0189fa8 c0359ca4 b6ec2cce c0359e00 b6ec2cce c099b6bc [ 169.730285] percpu_counter_add_batch from dst_destroy+0x11c/0x130 [ 169.736511] dst_destroy from rcu_core+0x3c8/0x1140 [ 169.741394] rcu_core from __do_softirq+0x130/0x538 [ 169.746307] __do_softirq from __irq_exit_rcu+0x14c/0x170 [ 169.751739] __irq_exit_rcu from irq_exit+0x10/0x30 [ 169.756622] irq_exit from call_with_stack+0x18/0x20 [ 169.761627] call_with_stack from __irq_usr+0x7c/0xa0 [ 169.766693] Exception stack(0xf0189fb0 to 0xf0189ff8) [ 169.771789] 9fa0: 6fce9940 1b458cad 0000003d b6b3e970 [ 169.779998] 9fc0: b6b3ea20 00028789 0001629c b6b3e8d8 000172a0 00000000 b633f000 b6b3f3a0 [ 169.788208] 9fe0: 00000000 b6b3e8d8 b6ec3835 b6ec2cce 000d0030 ffffffff [ 169.794860] Code: e5871004 ee1d4f90 e5901038 e1a0efcc (e7946001) Broadcast message from systemd-journald@am57xx-evm (Thu 2022[ 169.801116] ---[ end trace 0000000000000000 ]--- -04-28 17:45:03 UTC): kernel[290]: [ 169.313720] Internal [ 169.811279] Kernel panic - not syncing: Fatal exception in interrupt [ 169.823211] CPU1: stopping [ 169.825927] CPU: 1 PID: 308 Comm: rngd Tainted: G D 6.0.3-rc1 #1 [ 169.833343] Hardware name: Generic DRA74X (Flattened Device Tree) [ 169.839477] unwind_backtrace from show_stack+0x18/0x1c [ 169.844757] show_stack from dump_stack_lvl+0x58/0x70 [ 169.849822] dump_stack_lvl from do_handle_IPI+0x308/0x334 [ 169.855346] do_handle_IPI from ipi_handler+0x20/0x28 [ 169.860412] ipi_handler from handle_percpu_devid_irq+0xcc/0x320 [ 169.866485] handle_percpu_devid_irq from generic_handle_domain_irq+0x30/0x40 [ 169.873657] generic_handle_domain_irq from gic_handle_irq+0x90/0xb0 [ 169.880035] gic_handle_irq from generic_handle_arch_irq+0x34/0x44 [ 169.886260] generic_handle_arch_irq from call_with_stack+0x18/0x20 [ 169.892547] call_with_stack from __irq_svc+0x9c/0xb8 [ 169.897644] Exception stack(0xf0181ee0 to 0xf0181f28) [ 169.902709] 1ee0: 005807d2 00000000 77359400 00000010 00008272 c23b3300 f0181f80 c23b33c4 [ 169.910919] 1f00: c0427c70 c23b3400 c23b3450 00001c49 0058075e f0181f30 f6df0000 c0420798 [ 169.919158] 1f20: 600f0013 ffffffff [ 169.922637] __irq_svc from ktime_get_real_ts64+0x110/0x22c [ 169.928253] ktime_get_real_ts64 from posix_get_realtime_timespec+0x14/0x1c [ 169.935272] posix_get_realtime_timespec from sys_clock_gettime+0x64/0xc8 [ 169.942077] sys_clock_gettime from __sys_trace_return+0x0/0x10 [ 169.948028] Exception stack(0xf0181fa8 to 0xf0181ff0) [ 169.953124] 1fa0: 00000000 b61fea18 00000000 b61fea18 00000000 00000000 [ 169.961334] 1fc0: 00000000 b61fea18 b61feacc 00000193 000172a0 00000000 b59ff000 bee7f000 [ 169.969543] 1fe0: bee7f020 b61fe9c0 bee8055c bee806b8 [ 169.974639] ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]--- error: Oops: 5 [#1] SMP ARM Full test log: https://lkft.validation.linaro.org/scheduler/job/5708561#L5793 metadata: git_ref: linux-6.0.y git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git_sha: 84429734035197a6ab8e79c852d5e4e6ed744703 git_describe: v6.0-916-g844297340351 kernel_version: 6.0.3-rc1 kernel-config: https://builds.tuxbuild.com/2GMZBBq4CuTDk9rrHpkrP7lPMTT/config build-url: https://gitlab.com/mrchapp/linux/-/pipelines/671394419 artifact-location: https://builds.tuxbuild.com/2GMZBBq4CuTDk9rrHpkrP7lPMTT toolchain: gcc-10 vmlinux.xz: https://builds.tuxbuild.com/2GMZBBq4CuTDk9rrHpkrP7lPMTT/vmlinux.xz System.map: https://builds.tuxbuild.com/2GMZBBq4CuTDk9rrHpkrP7lPMTT/System.map -- Linaro LKFT https://lkft.linaro.org

2 years, 2 months

1
0
0 0

[PATCH] kasan: Enable KUnit integration whenever CONFIG_KUNIT is enabled

by David Gow

Enable the KASAN/KUnit integration even when the KASAN tests are disabled, as it's useful for testing other things under KASAN. Essentially, this reverts commit 49d9977ac909 ("kasan: check CONFIG_KASAN_KUNIT_TEST instead of CONFIG_KUNIT"). To mitigate the performance impact slightly, add a likely() to the check for a currently running test. There's more we can do for performance if/when it becomes more of a problem, such as only enabling the "expect a KASAN failure" support wif the KASAN tests are enabled, or putting the whole thing behind a "kunit tests are running" static branch (which I do plan to do eventually). Fixes: 49d9977ac909 ("kasan: check CONFIG_KASAN_KUNIT_TEST instead of CONFIG_KUNIT") Signed-off-by: David Gow <davidgow(a)google.com> --- Basically, hiding the KASAN/KUnit integration broke being able to just pass --kconfig_add CONFIG_KASAN=y to kunit_tool to enable KASAN integration. We didn't notice this, because usually CONFIG_KUNIT_ALL_TESTS is enabled, which in turn enables CONFIG_KASAN_KUNIT_TEST. However, using a separate .kunitconfig might result in failures being missed. Take, for example: ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_KASAN=y \ --kunitconfig drivers/gpu/drm/tests This should run the drm tests with KASAN enabled, but even if there's a KASAN failure (such as the one fixed by [1]), kunit_tool will report success. [1]: https://lore.kernel.org/dri-devel/20221019073239.3779180-1-davidgow@google.… --- mm/kasan/kasan.h | 2 +- mm/kasan/report.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index abbcc1b0eec5..afacef14c7f4 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -261,7 +261,7 @@ struct kasan_stack_ring { #endif /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ -#if IS_ENABLED(CONFIG_KASAN_KUNIT_TEST) +#if IS_ENABLED(CONFIG_KUNIT) /* Used in KUnit-compatible KASAN tests. */ struct kunit_kasan_status { bool report_found; diff --git a/mm/kasan/report.c b/mm/kasan/report.c index df3602062bfd..efa063b9d093 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -114,7 +114,7 @@ EXPORT_SYMBOL_GPL(kasan_restore_multi_shot); #endif -#if IS_ENABLED(CONFIG_KASAN_KUNIT_TEST) +#if IS_ENABLED(CONFIG_KUNIT) static void update_kunit_status(bool sync) { struct kunit *test; @@ -122,7 +122,7 @@ static void update_kunit_status(bool sync) struct kunit_kasan_status *status; test = current->kunit_test; - if (!test) + if (likely(!test)) return; resource = kunit_find_named_resource(test, "kasan_status"); -- 2.38.0.413.g74048e4d9e-goog

2 years, 2 months

2
4
0 0

[PATCH v1] selftests/landlock: Build without static libraries

by Mickaël Salaün

The only (forced) static test binary doesn't depend on libcap. Because using -lcap on systems that don't have such static library would fail (e.g. on Arch Linux), let's be more specific and require only dynamic libcap linking. Fixes: a52540522c95 ("selftests/landlock: Fix out-of-tree builds") Cc: Anders Roxell <anders.roxell(a)linaro.org> Cc: Guillaume Tucker <guillaume.tucker(a)collabora.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Shuah Khan <skhan(a)linuxfoundation.org> Cc: stable(a)vger.kernel.org Signed-off-by: Mickaël Salaün <mic(a)digikod.net> Link: https://lore.kernel.org/r/20221019200536.2771316-1-mic@digikod.net --- tools/testing/selftests/landlock/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile index 6632bfff486b..348e2dbdb4e0 100644 --- a/tools/testing/selftests/landlock/Makefile +++ b/tools/testing/selftests/landlock/Makefile @@ -3,7 +3,6 @@ # First run: make -C ../../../.. headers_install CFLAGS += -Wall -O2 $(KHDR_INCLUDES) -LDLIBS += -lcap LOCAL_HDRS += common.h @@ -13,10 +12,12 @@ TEST_GEN_PROGS := $(src_test:.c=) TEST_GEN_PROGS_EXTENDED := true -# Static linking for short targets: +# Short targets: +$(TEST_GEN_PROGS): LDLIBS += -lcap $(TEST_GEN_PROGS_EXTENDED): LDFLAGS += -static include ../lib.mk -# Static linking for targets with $(OUTPUT)/ prefix: +# Targets with $(OUTPUT)/ prefix: +$(TEST_GEN_PROGS): LDLIBS += -lcap $(TEST_GEN_PROGS_EXTENDED): LDFLAGS += -static base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780 -- 2.37.2

2 years, 2 months

1
0
0 0

[PATCH v11 0/2] SPDX: add copyleft-next-0.3.1

by Luis Chamberlain

As suggested by Thomas Gleixner, I'm following up to move on with the SPDX tag needed for copyleft-next-0.3.1. I've split this out from the test_sysfs selftest so to separate review from that. Changes on this v11: o Fixed a minor typo on patch #2 as noted by Kees Cook o Added Reviewed-by tags by Kees Cook Changes on this v10: o embraced paragraph from Thomas Gleixner which helps explain why the OR operator in the SPDX license name o dropped the GPL-2.0 and GPL-2.0+ tags as suggested by Thomas Gleixner as these are outdated (still valid) in the SPDX spec o trimmed the Cc list to remove the test_sysfs / block layer / fs folks as the test_sysfs stuff is now dropped from consideration in this series Prior to this the series was at v9 but it also had the test_sysfs and its changes, its history can be found here: https://lore.kernel.org/all/20211029184500.2821444-1-mcgrof@kernel.org/ Luis Chamberlain (2): LICENSES: Add the copyleft-next-0.3.1 license testing: use the copyleft-next-0.3.1 SPDX tag LICENSES/dual/copyleft-next-0.3.1 | 236 +++++++++++++++++++++++ lib/test_kmod.c | 12 +- lib/test_sysctl.c | 12 +- tools/testing/selftests/kmod/kmod.sh | 13 +- tools/testing/selftests/sysctl/sysctl.sh | 12 +- 5 files changed, 240 insertions(+), 45 deletions(-) create mode 100644 LICENSES/dual/copyleft-next-0.3.1 -- 2.35.1

2 years, 2 months

3
6
0 0

[PATCH 6.0 658/862] selftest: tpm2: Add Client.__del__() to close /dev/tpm* handle

by Greg Kroah-Hartman

From: Stefan Berger <stefanb(a)linux.ibm.com> [ Upstream commit 2d869f0b458547386fbcd8cf3004b271b7347b7f ] The following output can bee seen when the test is executed: test_flush_context (tpm2_tests.SpaceTest) ... \ /usr/lib64/python3.6/unittest/case.py:605: ResourceWarning: \ unclosed file <_io.FileIO name='/dev/tpmrm0' mode='rb+' closefd=True> An instance of Client does not implicitly close /dev/tpm* handle, once it gets destroyed. Close the file handle in the class destructor Client.__del__(). Fixes: 6ea3dfe1e0732 ("selftests: add TPM 2.0 tests") Cc: Shuah Khan <shuah(a)kernel.org> Cc: linux-kselftest(a)vger.kernel.org Cc: Jarkko Sakkinen <jarkko(a)kernel.org> Signed-off-by: Stefan Berger <stefanb(a)linux.ibm.com> Reviewed-by: Jarkko Sakkinen <jarkko(a)kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/tpm2/tpm2.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/tpm2/tpm2.py b/tools/testing/selftests/tpm2/tpm2.py index 057a4f49c79d..c7363c6764fc 100644 --- a/tools/testing/selftests/tpm2/tpm2.py +++ b/tools/testing/selftests/tpm2/tpm2.py @@ -371,6 +371,10 @@ class Client: fcntl.fcntl(self.tpm, fcntl.F_SETFL, flags) self.tpm_poll = select.poll() + def __del__(self): + if self.tpm: + self.tpm.close() + def close(self): self.tpm.close() -- 2.35.1

2 years, 2 months

1
0
0 0

[PATCH v3 0/4] Implement IOCTL to get and clear soft dirty PTE

by Muhammad Usama Anjum

Hello, This patch series implements a new ioctl on the pagemap proc fs file to get, clear and perform both get and clear at the same time atomically on the specified range of the memory. Soft-dirty PTE bit of the memory pages can be viewed by using pagemap procfs file. The soft-dirty PTE bit for the whole memory range of the process can be cleared by writing to the clear_refs file. This series adds features that weren't present earlier. - There is no atomic get soft-dirty PTE bit status and clear operation present. - The soft-dirty PTE bit of only a part of memory cannot be cleared. Historically, soft-dirty PTE bit tracking has been used in the CRIU project. The proc fs interface is enough for that as I think the process is frozen. We have the use case where we need to track the soft-dirty PTE bit for the running processes. We need this tracking and clear mechanism of a region of memory while the process is running to emulate the getWriteWatch() syscall of Windows. This syscall is used by games to keep track of dirty pages and keep processing only the dirty pages. This new ioctl can be used by the CRIU project and other applications which require soft-dirty PTE bit information. As in the current kernel there is no way to clear a part of memory (instead of clearing the Soft-Dirty bits for the entire process) and get+clear operation cannot be performed atomically, there are other methods to mimic this information entirely in userspace with poor performance: - The mprotect syscall and SIGSEGV handler for bookkeeping - The userfaultfd syscall with the handler for bookkeeping Some benchmarks can be seen [1]. This ioctl can be used by the CRIU project and other applications which require soft-dirty PTE bit information. The following operations are supported in this ioctl: - Get the pages that are soft-dirty. - Clear the pages which are soft-dirty. - The optional flag to ignore the VM_SOFTDIRTY and only track per page soft-dirty PTE bit There are two decisions which have been taken about how to get the output from the syscall. - Return offsets of the pages from the start in the vec - Stop execution when vec is filled with dirty pages These two arguments doesn't follow the mincore() philosophy where the output array corresponds to the address range in one to one fashion, hence the output buffer length isn't passed and only a flag is set if the page is present. This makes mincore() easy to use with less control. We are passing the size of the output array and putting return data consecutively which is offset of dirty pages from the start. The user can convert these offsets back into the dirty page addresses easily. Suppose, the user want to get first 10 dirty pages from a total memory of 100 pages. He'll allocate output buffer of size 10 and the ioctl will abort after finding the 10 pages. This behaviour is needed to support Windows' getWriteWatch(). The behaviour like mincore() can be achieved by passing output buffer of 100 size. This interface can be used for any desired behaviour. [1] https://lore.kernel.org/lkml/54d4c322-cd6e-eefd-b161-2af2b56aae24@collabora… Regards, Muhammad Usama Anjum Muhammad Usama Anjum (4): fs/proc/task_mmu: update functions to clear the soft-dirty PTE bit fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit selftests: vm: add pagemap ioctl tests mm: add documentation of the new ioctl on pagemap Documentation/admin-guide/mm/soft-dirty.rst | 42 +- fs/proc/task_mmu.c | 342 ++++++++++- include/uapi/linux/fs.h | 23 + tools/include/uapi/linux/fs.h | 23 + tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 2 + tools/testing/selftests/vm/pagemap_ioctl.c | 649 ++++++++++++++++++++ 7 files changed, 1050 insertions(+), 32 deletions(-) create mode 100644 tools/testing/selftests/vm/pagemap_ioctl.c -- 2.30.2

2 years, 2 months

6
23
0 0

kselftest/fixes build: 7 builds: 0 failed, 7 passed (v6.1-rc1-5-gcb05c81ada76)

by kernelci.org bot

kselftest/fixes build: 7 builds: 0 failed, 7 passed (v6.1-rc1-5-gcb05c81ada76) Full Build Summary: https://kernelci.org/build/kselftest/branch/fixes/kernel/v6.1-rc1-5-gcb05c8… Tree: kselftest Branch: fixes Git Describe: v6.1-rc1-5-gcb05c81ada76 Git Commit: cb05c81ada76a30a25a5f79b249375e33473af33 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git Built: 4 unique architectures --- For more info write to <info(a)kernelci.org>

2 years, 2 months

1
0
0 0

[PATCH v6 0/3] Introduce KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ macros

by Maíra Canal

Currently, in order to compare memory blocks in KUnit, the KUNIT_EXPECT_EQ or KUNIT_EXPECT_FALSE macros are used in conjunction with the memcmp function, such as: KUNIT_EXPECT_EQ(test, memcmp(foo, bar, size), 0); Although this usage produces correct results for the test cases, if the expectation fails the error message is not very helpful, indicating only the return of the memcmp function. Therefore, create a new set of macros KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ that compare memory blocks until a determined size. In case of expectation failure, those macros print the hex dump of the memory blocks, making it easier to debug test failures for memory blocks. The v6 has some changes on the first patch, due to rebase on top of Linux 6.1, specially the renaming of KUNIT_ASSERTION macro to _KUNIT_FAILED (97d453bc4007d4ac148c2ba89904026612b91ec9). Moreover, the DRM KUnit tests were mainlined in 6.1. The first patch of the series introduces the KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ. The second patch adds an example of memory block expectations on the kunit-example-test.c. And the last patch replaces the KUNIT_EXPECT_EQ for KUNIT_EXPECT_MEMEQ on the existing occurrences. Best Regards, - Maíra Canal v1 -> v2: https://lore.kernel.org/linux-kselftest/2a0dcd75-5461-5266-2749-808f638f4c5… - Change "determinated" to "specified" (Daniel Latypov). - Change the macro KUNIT_EXPECT_ARREQ to KUNIT_EXPECT_MEMEQ, in order to make it easier for users to infer the right size unit (Daniel Latypov). - Mark the different bytes on the failure message with a <> (Daniel Latypov). - Replace a constant number of array elements for ARRAY_SIZE() (André Almeida). - Rename "array" and "expected" variables to "array1" and "array2" (Daniel Latypov). v2 -> v3: https://lore.kernel.org/linux-kselftest/20220802212621.420840-1-mairacanal@… - Make the bytes aligned at output. - Add KUNIT_SUBSUBTEST_INDENT to the output for the indentation (Daniel Latypov). - Line up the trailing \ at macros using tabs (Daniel Latypov). - Line up the params to the functions (Daniel Latypov). - Change "Increament" to "Augment" (Daniel Latypov). - Use sizeof() for array sizes (Daniel Latypov). - Add Daniel Latypov's tags. v3 -> v4: https://lore.kernel.org/linux-kselftest/CABVgOSm_59Yr82deQm2C=18jjSv_akmn66… - Fix wrapped lines by the mail client (David Gow). - Mention on documentation that KUNIT_EXPECT_MEMEQ is not recommended for structured data (David Gow). - Add Muhammad Usama Anjum's tag. v4 -> v5: https://lore.kernel.org/linux-kselftest/20220808125237.277126-1-mairacanal@… - Rebase on top of drm-misc-next. - Add David Gow's tags. v5 -> v6: https://lore.kernel.org/linux-kselftest/20220921014515.113062-1-mairacanal@… - Rebase on top of Linux 6.1. - Change KUNIT_ASSERTION macro to _KUNIT_FAILED. Maíra Canal (3): kunit: Introduce KUNIT_EXPECT_MEMEQ and KUNIT_EXPECT_MEMNEQ macros kunit: Add KUnit memory block assertions to the example_all_expect_macros_test kunit: Use KUNIT_EXPECT_MEMEQ macro .../gpu/drm/tests/drm_format_helper_test.c | 12 +-- include/kunit/assert.h | 33 +++++++ include/kunit/test.h | 87 +++++++++++++++++++ lib/kunit/assert.c | 56 ++++++++++++ lib/kunit/kunit-example-test.c | 7 ++ net/core/dev_addr_lists_test.c | 4 +- 6 files changed, 191 insertions(+), 8 deletions(-) -- 2.37.3

2 years, 2 months

3
6
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror October 2022