Hi!
I just checked out this regression but I think there's something odd
going on in the setup that is running the tests. When I run the test
locally, the relevant part of the logs looks like this:
(gdb) PASS: gdb.threads/threadcrash.exp: test_live_inferior:
continue to breakpoint: running to breakpoint
print $_inferior_thread_count^M
$1 = 7^M
(gdb) PASS: gdb.threads/threadcrash.exp: test_live_inferior:
$thread_count == 7
thread apply all backtrace^M
^M
< lots of GDB output >
(gdb) PASS: gdb.threads/threadcrash.exp: test_live_inferior: Get
thread information
PASS: gdb.threads/threadcrash.exp: test_live_inferior: $unwind_fail
== false
PASS: gdb.threads/threadcrash.exp: test_live_inferior:
$thread_count == [llength $test_list]
Whereas the failed log reads like this:
(gdb) PASS: gdb.threads/threadcrash.exp: test_live_inferior:
continue to breakpoint: running to breakpoint
print $_inferior_thread_count
$1 = 7PASS: gdb.threads/threadcrash.exp: test_live_inferior:
$thread_count == 7
(gdb) PASS: gdb.threads/threadcrash.exp: test_live_inferior: Get
thread information
PASS: gdb.threads/threadcrash.exp: test_live_inferior: $unwind_fail
== false
FAIL: gdb.threads/threadcrash.exp: test_live_inferior:
$thread_count == [llength $test_list]
thread apply all backtrace
Notice how the gdb command to "apply all backtrace", which is used to
create the test_list variable, happens after checking if the variable
has been set correctly.
I have no clue how things can get so out of sync...
--
Cheers,
Guinevere Larsen
She/Her/Hers
On 13/02/2024 17:09, ci_notify@linaro.org wrote:
> Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
>
> We appreciate that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.
>
> In gdb_check master-aarch64 after:
>
> | 2 patches in gdb
> | Patchwork URL:
https://patchwork.sourceware.org/patch/85659
> | f687941ee52 gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols
> | 2e746d0ae56 gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets
> | ... applied on top of baseline commit:
> | 7e4208a3f5d [gdb/tdep] Fix reverse execution of LDR(immediate) T4
>
> FAIL: 5 regressions
>
> regressions.sum:
> === gdb tests ===
>
> Running gdb:gdb.threads/threadcrash.exp ...
> FAIL: gdb.threads/threadcrash.exp: test_corefile: $thread_count == [llength $test_list]
> FAIL: gdb.threads/threadcrash.exp: test_corefile: getting thread count (got interactive prompt)
> FAIL: gdb.threads/threadcrash.exp: test_corefile: loading_corefile
> FAIL: gdb.threads/threadcrash.exp: test_gcore: $thread_count == [llength $test_list]
> FAIL: gdb.threads/threadcrash.exp: test_live_inferior: $thread_count == [llength $test_list]
>
>
> You can find the failure logs in *.log.1.xz files in
> -
https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-precommit/1701/arti...
> The full lists of regressions and progressions as well as configure and make commands are in
> -
https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-precommit/1701/arti...
> The list of [ignored] baseline and flaky failures are in
> -
https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-precommit/1701/arti...
>
> The configuration of this build is:
> CI config tcwg_gdb_check master-aarch64
>
> -----------------8<--------------------------8<--------------------------8<--------------------------
> The information below can be used to reproduce a debug environment:
>
> Current build :
https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-precommit/1701/arti...
> Reference build :
https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-build/814/artifact/...
