On Tue, 30 Nov 2010 16:06:32 +0000 (UTC) "Joseph S. Myers" joseph@codesourcery.com wrote:
On Tue, 30 Nov 2010, Julian Brown wrote:
* defaults.h (VECTOR_ELEMENTS_BIG_ENDIAN): Define.
Apart from the point that new target macros should be hooks, the *very first* thing to do with any new macro or hook is to write the .texi documentation, which appears to be missing from this patch. This is best done before making any consequent code changes. That documentation needs to make clear:
I did say I didn't like that bit much :-). With this particular patch (intended merely as a stop-gap measure until we get "array order" loads/stores working with the vectorizer), I don't think it's a good idea to introduce changes to GENERIC/GIMPLE semantics, and you're quite right that adding that macro (or an equivalent target hook) implies doing exactly that. That wasn't my intention at all at this stage, though we may eventually end up doing something similar.
I'll try to think of an alternative way of getting the vectorizer to do what I want, for now...
Thanks,
Julian