I was able to reproduce the regressions. The 6 regressions were caused by 2
issues with the implementation, which are fixed by
https://github.com/llvm/llvm-project/pull/101538.
The 6 corresponding tests also run correctly with this PR applied.
--
Leandro Lupori
https://www.linaro.org
On Thu, 1 Aug 2024 at 03:10, Maxim Kuvyrkov
maxim.kuvyrkov@linaro.org
wrote:
> Hi Leandro,
>
> Our Flang CI is running in test mode, and it already catches regressions!
>
> > On Aug 1, 2024, at 01:27, ci_notify@linaro.org wrote:
> >
> > Dear contributor, our automatic CI has detected problems related to your
> patch(es). Please find some details below. If you have any questions,
> please follow up on linaro-toolchain@lists.linaro.org mailing list,
> Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain
> developer on the usual project channel.
> >
> > We appreciate that it might be difficult to find the necessary logs or
> reproduce the issue locally. If you can't get what you need from our CI
> within minutes, let us know and we will be happy to help.
> >
> > We track this report status in
>
https://linaro.atlassian.net/browse/LLVM-1300 , please let us know if you
> are looking at the problem and/or when you have a fix.
> >
> > In CI config tcwg_flang_test/main-aarch64-Ofast-sve_vls-lto-lld after:
> >
> > | commit llvmorg-20-init-943-g366eade911b5
> > | Author: Leandro Lupori
leandro.lupori@linaro.org
> > | Date: Wed Jul 31 14:39:06 2024 -0300
> > |
> > | [flang][OpenMP] Reland Fix copyprivate semantic checks (#95799)
> (#101009)
> > |
> > | There are some cases in which variables used in OpenMP constructs
> > | are predetermined as private. The semantic checks for copyprivate
> > | were not handling those cases.
> > |
> > | Besides that, shared symbols were not being properly represented
> > | ... 9 lines of the commit log omitted.
> >
> > FAIL: 7 regressions: 7 improvements
> >
> > regressions.sum:
> > === test-suite tests ===
> >
> > Running test-suite:Fujitsu/Fortran/0141 ...
> > FAIL: test-suite :: Fujitsu/Fortran/0141/Fujitsu-Fortran-0141_0019.test
>
> This means that after your patch the test that could not compile before,
> now compiles, but fails to run correctly. This is an improvement.
>
> >
> > Running test-suite:Fujitsu/Fortran/0153 ...
> > NOEXE: test-suite :: Fujitsu/Fortran/0153/Fujitsu-Fortran-0153_0234.test
> > NOEXE: test-suite :: Fujitsu/Fortran/0153/Fujitsu-Fortran-0153_0235.test
> > NOEXE: test-suite :: Fujitsu/Fortran/0153/Fujitsu-Fortran-0153_0237.test
>
> These tests go the other way -- they used to fail at runtime before, but
> now they fail to compile.
>
> >
> > ... and 5 more entries
> >
> > improvements.sum:
> > === test-suite tests ===
> >
> > Running test-suite:Fujitsu/Fortran/0141 ...
> > NOEXE: test-suite :: Fujitsu/Fortran/0141/Fujitsu-Fortran-0141_0019.test
> >
> > Running test-suite:Fujitsu/Fortran/0153 ...
> > FAIL: test-suite :: Fujitsu/Fortran/0153/Fujitsu-Fortran-0153_0237.test
> > FAIL: test-suite :: Fujitsu/Fortran/0153/Fujitsu-Fortran-0153_0234.test
> > FAIL: test-suite :: Fujitsu/Fortran/0153/Fujitsu-Fortran-0153_0235.test
> >
> > ... and 5 more entries
>
> Please investigate, and let me know if you need any help in reproducing or
> troubleshooting these.
>
> Thanks!
>
> --
> Maxim Kuvyrkov
>
https://www.linaro.org
>
>
>
> >
> > You can find the failure logs in *.log.1.xz files in
> > -
>
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vls-lto-ll...
> > The full lists of regressions and improvements as well as configure and
> make commands are in
> > -
>
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vls-lto-ll...
> > The list of [ignored] baseline and flaky failures are in
> > -
>
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vls-lto-ll...
> >
> > The configuration of this build is:
> > CI config tcwg_flang_test/main-aarch64-Ofast-sve_vls-lto-lld
> >
> >
> -----------------8<--------------------------8<--------------------------8<--------------------------
> > The information below can be used to reproduce a debug environment:
> >
> > Current build :
>
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vls-lto-ll...
> > Reference build :
>
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vls-lto-ll...
> >
> > Reproduce last good and first bad builds:
>
https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
> >
> > Full commit :
>
https://github.com/llvm/llvm-project/commit/366eade911b54878c9cc1835d2544fb4...
> >
> > List of configurations that regressed due to this commit :
> > * tcwg_flang_test
> > ** main-aarch64-Ofast-sve_vls-lto-lld
> > *** FAIL: 7 regressions: 7 improvements
> > ***
>
https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/llvm/sh...
> > ***
>
https://ci.linaro.org/job/tcwg_flang_test--main-aarch64-Ofast-sve_vls-lto-ll...
>
>
>