On Thu, 4 Jun 2015, Jim Wilson wrote:
On Wed, Jun 3, 2015 at 4:15 PM, Nicolas Pitre nicolas.pitre@linaro.org wrote:
I created a patch on top of upstream binutils for a feature I need which should be universally useful as well. Now I have 3 questions for you:
- Does it look sane enough?
You added the option docs into the .section docs. It is certainly OK to talk about it here, but there is also a list of all options in the docs, and the new option needs to be documented here also. One could perhaps refer to the other.
OK.
Otherwise, the patch looks OK, but I have little experience using macros, so I'm not sure if there might be a better way to do this.
I provided a macro based example to simplify things. But my primary use case involves inline assembly from C code, such as included by the put_user() macro in the Linux kernel.
I'm also not sure how the other binutils maintainers would feel about the design. It would have to be discussed on the binutils mailing list.
Fair enough. Given your other comments I'll follow up on that list.
Thanks for the review.
Nicolas