On Mon, Oct 4, 2010 at 10:26 PM, Yao Qi yao.qi@linaro.org wrote:
On 10/04/2010 12:05 PM, Zach Welch wrote:
I made a patch for ltrace that adds support for Thumb-2. There's not much to it, but it allows me to trace applications built for Cortex-A8. Without it, users will experience this bug:
https://bugs.launchpad.net/ubuntu/+source/ltrace/+bug/639796
Unfortunately, it appears that the upstream tree is not well-maintained. I posted it to the mailing list for the project, but others' patches have been ignored for many months. However, my post precipitated another contributor to offer to maintain the package.
I also posted this patch as the proposed solution for the above LP bug, which should allow Linaro to benefit from the work without worrying about upstream. In fact, a new version of the package appears to have been released that includes my patch (0.5.3-2ubuntu6). Please give this updated package a whirl and let me know if there is more work to be done.
Thoughts? Unless I hear feedback from others, I will assume that this tool now works for Cortex-A[89] and move on to other tasks.
The patch looks fine to me. IIRC, there is a testsuite in ltrace. Do we want to add a testcase for this bug? It is good if we can run ltrace testsuite.
Hi Zach. I'd like to give the Secondary Projects idea[1] a spin on this. The goal is to make any improvements we've done available early and then be superseded by upstream in the future. This is especially relevant when upstream is quiet like with ltrace.
Could you please: * Mention the idea to upstream to see if anyone disagrees * See if anyone upstream has other ARM or x86 patches to include * Test under ARM Thumb-2, i686, and x86_64 * Spin a tarball to go out with the 2010.11 release.
Ubuntu has already picked up your change so there's no need for binary builds. Please spend some time on the testsuite to see how ARM and x86 compare and to make sure the suite runs as part of the Ubuntu build.
Give me a yell on IRC or email if you need any help,
-- Michael [1] https://wiki.linaro.org/WorkingGroups/ToolChain