Guinevere Larsen blarsen@redhat.com writes:
On 13/02/2024 22:01, Thiago Jung Bauermann wrote:
Hello again,
Thiago Jung Bauermann thiago.bauermann@linaro.org writes:
diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp b/gdb/testsuite/gdb.threads/threadcrash.exp index 3905ad6f9362..944fbcac1b18 100644 --- a/gdb/testsuite/gdb.threads/threadcrash.exp +++ b/gdb/testsuite/gdb.threads/threadcrash.exp @@ -28,7 +28,7 @@ proc test_thread_count {} { set thread_count 0 gdb_test_multiple "print $_inferior_thread_count" "getting thread count" {
- -re ".* = ([0-9]+).*" {
- -re ".* = ([0-9]+)\r\n$::gdb_prompt " { set thread_count $expect_out(1,string) gdb_assert {$thread_count == 7} }
It occurred to me that this gdb_test_multiple call is very similar to the function get_valueof in lib/gdb.exp, so one suggestion is to use that function instead. It uses "-re -wrap" so it expects the GDB prompt.
This makes a lot of sense. thanks for the help! And for making this CI, it is clearly making a difference! :D
Thank you! We're glad it is helping!