Hello,
# [GNU-767] Support changing SVE vector length in remote debugging
- Continued preparing patches for upstream submission. Did some final
code and testcase cleanups, updated/rewrote patch descriptions, wrote
the cover letter and the list of changes from v2.
- Posted the patches upstream¹.
--
Thiago
¹ https://inbox.sourceware.org/gdb-patches/20230130044518.3322695-1-thiago.ba…
Project Stratos
===============
- reading up on the linux-mm subsystem
- learning about struct vma_area
[proposal for Unprivilaged VirtIO API]
<https://docs.google.com/document/d/18ijlX2Lguejyo3BV8Tri5Y_d1SmozocBIk2ajgq…>
FEAT_RME, CCA Realms ([QEMU-466])
=================================
- more review of [PATCH v5 00/36] tcg: Support for Int128 with helpers
Message-Id: <20230126043824.54819-1-richard.henderson(a)linaro.org>
[QEMU-466] <https://linaro.atlassian.net/browse/QEMU-466>
QEMU Upstream Work ([UM-2])
===========================
- updated maintainer trees, running [CI over weekend]
- posted [PULL 00/35] Testing, docs, semihosting and plugin updates
Message-Id: <20230126112250.2584701-1-alex.bennee(a)linaro.org>
[UM-2] <https://linaro.atlassian.net/browse/UM-2>
[CI over weekend]
<https://gitlab.com/stsquad/qemu/-/pipelines/753447926>
Current Review Queue
====================
TODO [RFC PATCH 00/16] arm: Run Arm CCA VMs with KVM
Message-Id: <20230127150727.612594-1-jean-philippe(a)linaro.org>
==================================================================================================================
TODO [QEMU][PATCH v4 00/10] Introduce xenpvh machine for arm architecture
Message-Id: <20230125085407.7144-1-vikram.garhwal(a)amd.com>
===================================================================================================================================
TODO [PATCH v3 0/3] tcg: add perfmap and jitdump
Message-Id: <20230111014705.2275040-1-iii(a)linux.ibm.com>
========================================================================================================
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Progress:
* UM-2 [QEMU upstream maintainership]
- usual upstream maintenance tasks
* QEMU-471 [QEMU ARM v9.0 Baseline CPU for TCG]
- FEAT_FGT: finished coding, did some testing, sent patches for review
-- PMM
After gdb-13-branchpoint-527-g46758593515 commit 4675859351582f017b495ff13fb2ea72a99834af
Author: Tom Tromey <tom(a)tromey.com>
Rename to allow_ifunc_tests
the following benchmarks slowed down by more than 3%:
- 465.tonto failed to build
Below reproducer instructions can be used to re-build both "first_bad" and "last_good" cross-toolchains used in this bisection. Naturally, the scripts will fail when triggerring benchmarking jobs if you don\'t have access to Linaro TCWG CI.
Configuration:
- Benchmark: SPEC CPU2006
- Toolchain: GCC + Glibc + GNU Linker
- Version: all components were built from their tip of trunk
- Target: aarch64-linux-gnu
- Compiler flags: -O3
- Hardware:
This benchmarking CI is work-in-progress, and we welcome feedback and suggestions at linaro-toolchain(a)lists.linaro.org . In our improvement plans is to add support for SPEC CPU2017 benchmarks and provide "perf report/annotate" data behind these reports.
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
For latest status see comments in https://linaro.atlassian.net/browse/GNU-692 .
Status of gdb-13-branchpoint-527-g46758593515 commit for tcwg_bmk-code_speed-spec2k6:
commit 4675859351582f017b495ff13fb2ea72a99834af
Author: Tom Tromey <tom(a)tromey.com>
Date: Sun Jan 8 11:41:19 2023 -0700
Rename to allow_ifunc_tests
This changes skip_ifunc_tests to invert the sense, and renames it to
allow_ifunc_tests.
* gnu-aarch64-master-O3
** After gdb-13-branchpoint-527-g46758593515 commit 4675859351582f017b495ff13fb2ea72a99834af
** Author: Tom Tromey <tom(a)tromey.com>
**
** Rename to allow_ifunc_tests
**
** the following benchmarks slowed down by more than 3%:
** - 465.tonto failed to build
** https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3…
Bad build: https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3…
Good build: https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3…
Reproduce current build:
<cut>
mkdir -p investigate-binutils-4675859351582f017b495ff13fb2ea72a99834af
cd investigate-binutils-4675859351582f017b495ff13fb2ea72a99834af
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests for bad and good builds
mkdir -p bad/artifacts good/artifacts
curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3… --fail
curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3… --fail
# Reproduce bad build
(cd bad; ../jenkins-scripts/tcwg_bmk-build.sh ^^ true %%rr[top_artifacts] artifacts)
# Reproduce good build
(cd good; ../jenkins-scripts/tcwg_bmk-build.sh ^^ true %%rr[top_artifacts] artifacts)
</cut>
Full commit (up to 1000 lines):
<cut>
commit 4675859351582f017b495ff13fb2ea72a99834af
Author: Tom Tromey <tom(a)tromey.com>
Date: Sun Jan 8 11:41:19 2023 -0700
Rename to allow_ifunc_tests
This changes skip_ifunc_tests to invert the sense, and renames it to
allow_ifunc_tests.
---
gdb/testsuite/gdb.base/gnu-ifunc.exp | 2 +-
gdb/testsuite/gdb.compile/compile-ifunc.exp | 2 +-
gdb/testsuite/lib/gdb.exp | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.base/gnu-ifunc.exp b/gdb/testsuite/gdb.base/gnu-ifunc.exp
index 967d1e053e7..81119f764b8 100644
--- a/gdb/testsuite/gdb.base/gnu-ifunc.exp
+++ b/gdb/testsuite/gdb.base/gnu-ifunc.exp
@@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-require !skip_shlib_tests !skip_ifunc_tests
+require !skip_shlib_tests allow_ifunc_tests
standard_testfile .c
set staticexecutable ${testfile}-static
diff --git a/gdb/testsuite/gdb.compile/compile-ifunc.exp b/gdb/testsuite/gdb.compile/compile-ifunc.exp
index bfbe65a503b..990d35a53f6 100644
--- a/gdb/testsuite/gdb.compile/compile-ifunc.exp
+++ b/gdb/testsuite/gdb.compile/compile-ifunc.exp
@@ -15,7 +15,7 @@
load_lib compile-support.exp
-require !skip_ifunc_tests
+require allow_ifunc_tests
standard_testfile
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 7143908bbc2..3a1936ffc82 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3972,17 +3972,17 @@ gdb_caching_proc has_int128_cxx {
return [gdb_int128_helper c++]
}
-# Return true if the IFUNC feature is unsupported.
-gdb_caching_proc skip_ifunc_tests {
+# Return true if the IFUNC feature is supported.
+gdb_caching_proc allow_ifunc_tests {
if [gdb_can_simple_compile ifunc {
extern void f_ ();
typedef void F (void);
F* g (void) { return &f_; }
void f () __attribute__ ((ifunc ("g")));
} object] {
- return 0
- } else {
return 1
+ } else {
+ return 0
}
}
</cut>
Hello,
# [GNU-767] Support changing SVE vector length in remote debugging
- Continued preparing patches for upstream submission. Realised I had to
document my changes to the remote protocol in the GDB manual, so did
that. Also making small code cleanups and updating/rewriting patch
descriptions.
- Noticed I could to a small optimisation in one patch, but it would
involve a lot of refactoring to move GDB-specific code so that it could
also be used by gdbserver, so saved the WIP branch for later.
# TCWG CI
- Investigated failure report from yesterday's email. Reproduced on
tcwg-jade-03 with a slightly different build failure, but wasn't able to
make much progress¹.
--
Thiago
¹ https://lists.linaro.org/archives/list/linaro-toolchain@lists.linaro.org/th…
Progress:
* UM-2 [QEMU upstream maintainership]
- usual upstream maintenance tasks
* QEMU-471 [QEMU ARM v9.0 Baseline CPU for TCG]
- FEAT_FGT getting closer towards being done: I just have
to mark up the ARMCPRegInfo structs for HDFGRTR traps, and
write the code to handle traps on ERET and SVC
-- PMM
After gdb-13-branchpoint-388-g71fa8692930 commit 71fa8692930cd5fc3f332415cf642d3aa5f55fc6
Author: Mike Frysinger <vapier(a)gentoo.org>
sim: cris: move arch-specific file compilation to top-level
the following benchmarks slowed down by more than 3%:
- 481.wrf failed to build
- 416.gamess failed to build
Below reproducer instructions can be used to re-build both "first_bad" and "last_good" cross-toolchains used in this bisection. Naturally, the scripts will fail when triggerring benchmarking jobs if you don\'t have access to Linaro TCWG CI.
Configuration:
- Benchmark: SPEC CPU2006
- Toolchain: GCC + Glibc + GNU Linker
- Version: all components were built from their tip of trunk
- Target: arm-linux-gnueabihf
- Compiler flags: -O3 -flto -marm
- Hardware:
This benchmarking CI is work-in-progress, and we welcome feedback and suggestions at linaro-toolchain(a)lists.linaro.org . In our improvement plans is to add support for SPEC CPU2017 benchmarks and provide "perf report/annotate" data behind these reports.
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
For latest status see comments in https://linaro.atlassian.net/browse/GNU-692 .
Status of gdb-13-branchpoint-388-g71fa8692930 commit for tcwg_bmk-code_speed-spec2k6:
commit 71fa8692930cd5fc3f332415cf642d3aa5f55fc6
Author: Mike Frysinger <vapier(a)gentoo.org>
Date: Sun Jan 1 13:40:11 2023 -0500
sim: cris: move arch-specific file compilation to top-level
* gnu-arm-master-O3_LTO
** After gdb-13-branchpoint-388-g71fa8692930 commit 71fa8692930cd5fc3f332415cf642d3aa5f55fc6
** Author: Mike Frysinger <vapier(a)gentoo.org>
**
** sim: cris: move arch-specific file compilation to top-level
**
** the following benchmarks slowed down by more than 3%:
** - 481.wrf failed to build
** - 416.gamess failed to build
** https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-arm-master-O3_LTO…
Bad build: https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-arm-master-O3_LTO…
Good build: https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-arm-master-O3_LTO…
Reproduce current build:
<cut>
mkdir -p investigate-binutils-71fa8692930cd5fc3f332415cf642d3aa5f55fc6
cd investigate-binutils-71fa8692930cd5fc3f332415cf642d3aa5f55fc6
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests for bad and good builds
mkdir -p bad/artifacts good/artifacts
curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-arm-master-O3_LTO… --fail
curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-arm-master-O3_LTO… --fail
# Reproduce bad build
(cd bad; ../jenkins-scripts/tcwg_bmk-build.sh ^^ true %%rr[top_artifacts] artifacts)
# Reproduce good build
(cd good; ../jenkins-scripts/tcwg_bmk-build.sh ^^ true %%rr[top_artifacts] artifacts)
</cut>
Full commit (up to 1000 lines):
<cut>
commit 71fa8692930cd5fc3f332415cf642d3aa5f55fc6
Author: Mike Frysinger <vapier(a)gentoo.org>
Date: Sun Jan 1 13:40:11 2023 -0500
sim: cris: move arch-specific file compilation to top-level
---
sim/Makefile.in | 3 ---
sim/cris/local.mk | 3 ---
2 files changed, 6 deletions(-)
diff --git a/sim/Makefile.in b/sim/Makefile.in
index 435c36b2b83..0ad692126e7 100644
--- a/sim/Makefile.in
+++ b/sim/Makefile.in
@@ -4801,9 +4801,6 @@ testsuite/common/bits64m63.c: testsuite/common/bits-gen$(EXEEXT) testsuite/commo
@SIM_ENABLE_ARCH_cr16_TRUE@ $(AM_V_GEN)$< >$@
@SIM_ENABLE_ARCH_cris_TRUE@$(cris_libsim_a_OBJECTS) $(cris_libsim_a_LIBADD): cris/hw-config.h
-@SIM_ENABLE_ARCH_cris_TRUE@cris/%.o: cris/%.c
-@SIM_ENABLE_ARCH_cris_TRUE@ $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
-
@SIM_ENABLE_ARCH_cris_TRUE@cris/%.o: common/%.c
@SIM_ENABLE_ARCH_cris_TRUE@ $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
@SIM_ENABLE_ARCH_cris_TRUE@cris/modules.c: | $(cris_BUILD_OUTPUTS)
diff --git a/sim/cris/local.mk b/sim/cris/local.mk
index 912ca12a32f..3950baed7a1 100644
--- a/sim/cris/local.mk
+++ b/sim/cris/local.mk
@@ -47,9 +47,6 @@ $(%C%_libsim_a_OBJECTS) $(%C%_libsim_a_LIBADD): %D%/hw-config.h
noinst_LIBRARIES += %D%/libsim.a
-%D%/%.o: %D%/%.c
- $(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
-
%D%/%.o: common/%.c
$(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
</cut>
After glibc-2.36.9000-435-g569cfcc6bf commit 569cfcc6bf35c28112ca8d7112e9eb4a22bed5b8
Author: Samuel Thibault <samuel.thibault(a)ens-lyon.org>
hurd: Fix _NOFLSH value
the following benchmarks slowed down by more than 3%:
- 459.GemsFDTD failed to build
- 436.cactusADM failed to build
Below reproducer instructions can be used to re-build both "first_bad" and "last_good" cross-toolchains used in this bisection. Naturally, the scripts will fail when triggerring benchmarking jobs if you don\'t have access to Linaro TCWG CI.
For your convenience, we have uploaded tarballs with pre-processed source and assembly files at:
- First_bad save-temps: $FIRST_BAD_ARTIFACTS/save-temps/
- Last_good save-temps: $LAST_GOOD_ARTIFACTS/save-temps/
- Baseline save-temps: $BASELINE_ARTIFACTS/save-temps/
Configuration:
- Benchmark: SPEC CPU2006
- Toolchain: GCC + Glibc + GNU Linker
- Version: all components were built from their tip of trunk
- Target: aarch64-linux-gnu
- Compiler flags: -O3 -flto
- Hardware:
This benchmarking CI is work-in-progress, and we welcome feedback and suggestions at linaro-toolchain(a)lists.linaro.org . In our improvement plans is to add support for SPEC CPU2017 benchmarks and provide "perf report/annotate" data behind these reports.
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
For latest status see comments in https://linaro.atlassian.net/browse/GNU-692 .
Status of glibc-2.36.9000-435-g569cfcc6bf commit for tcwg_bmk-code_speed-spec2k6:
commit 569cfcc6bf35c28112ca8d7112e9eb4a22bed5b8
Author: Samuel Thibault <samuel.thibault(a)ens-lyon.org>
Date: Sun Jan 15 20:54:42 2023 +0100
hurd: Fix _NOFLSH value
shifting 1 (thus an integer) left 31 bit is undefined behavior. We have to
make it an unsigned integer to properly get 0x80000000 (like done in other
places).
* gnu-aarch64-master-O3_LTO
** After glibc-2.36.9000-435-g569cfcc6bf commit 569cfcc6bf35c28112ca8d7112e9eb4a22bed5b8
** Author: Samuel Thibault <samuel.thibault(a)ens-lyon.org>
**
** hurd: Fix _NOFLSH value
**
** the following benchmarks slowed down by more than 3%:
** - 459.GemsFDTD failed to build
** - 436.cactusADM failed to build
** https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3…
Bad build: https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3…
Good build: https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3…
Reproduce current build:
<cut>
mkdir -p investigate-glibc-569cfcc6bf35c28112ca8d7112e9eb4a22bed5b8
cd investigate-glibc-569cfcc6bf35c28112ca8d7112e9eb4a22bed5b8
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests for bad and good builds
mkdir -p bad/artifacts good/artifacts
curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3… --fail
curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_bmk-code_speed-spec2k6-gnu-aarch64-master-O3… --fail
# Reproduce bad build
(cd bad; ../jenkins-scripts/tcwg_bmk-build.sh ^^ true %%rr[top_artifacts] artifacts)
# Reproduce good build
(cd good; ../jenkins-scripts/tcwg_bmk-build.sh ^^ true %%rr[top_artifacts] artifacts)
</cut>
Full commit (up to 1000 lines):
<cut>
commit 569cfcc6bf35c28112ca8d7112e9eb4a22bed5b8
Author: Samuel Thibault <samuel.thibault(a)ens-lyon.org>
Date: Sun Jan 15 20:54:42 2023 +0100
hurd: Fix _NOFLSH value
shifting 1 (thus an integer) left 31 bit is undefined behavior. We have to
make it an unsigned integer to properly get 0x80000000 (like done in other
places).
---
bits/termios.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bits/termios.h b/bits/termios.h
index ae62d00853..4439c2f14e 100644
--- a/bits/termios.h
+++ b/bits/termios.h
@@ -246,7 +246,7 @@ struct termios
# define NOKERNINFO (1 << 25) /* Disable VSTATUS. */
# define PENDIN (1 << 29) /* Retype pending input (state). */
#endif
-#define _NOFLSH (1 << 31) /* Disable flush after interrupt. */
+#define _NOFLSH (1U << 31) /* Disable flush after interrupt. */
#define NOFLSH _NOFLSH
/* Control characters. */
</cut>