My brain is slightly fried after trying to catch up on the thread for close to 2h. So forgive me if I'm missing something. This applies to all emails I'm about to send :)

On Sun, 5 Nov 2023 18:44:11 -0800 Mina Almasry wrote:

• trigger_device_reset();

The user space must not be responsible for the reset. We can add some temporary "recreate page pools" ndo until the queue API is ready.

But it should not be visible to the user in any way.

And then the kernel can issue the same reset when the netlink socket dies to flush device free lists.

Maybe we should also add a "allow device/all-queues reload" flag to the netlink API to differentiate drivers which can't implement full queue API later on. We want to make sure the defaults work well in our "target design", rather than at the first stage. And target design will reload queues one by one.