op 07-11-13 22:11, Rom Lemarchand schreef:
Hi Maarten, I tested your changes and needed the attached patch: behavior now seems equivalent as android sync. I haven't tested performance.
The issue resolved by this patch happens when i_b < b->num_fences and i_a
= a->num_fences (or vice versa). Then, pt_a is invalid and so
dereferencing pt_a->context causes a crash.
Yeah, I pushed my original fix. I intended to keep android userspace behavior the same, and I tried to keep the kernelspace the api same as much as I could. If peformance is the same, or not noticeably worse, would there be any objections on the android side about renaming dma-fence to syncpoint, and getting it in mainline?
~Maarten
I ran some benchmarks and things seem to be running about the same. No one on our graphics team seemed concerned about the change.
The only concern I heard was about the increased complexity of the new sync code as opposed to the old sync framework which tried to keep things straightforward.
On Fri, Nov 8, 2013 at 3:43 AM, Maarten Lankhorst < maarten.lankhorst@canonical.com> wrote:
op 07-11-13 22:11, Rom Lemarchand schreef:
Hi Maarten, I tested your changes and needed the attached patch: behavior now seems equivalent as android sync. I haven't tested performance.
The issue resolved by this patch happens when i_b < b->num_fences and i_a
= a->num_fences (or vice versa). Then, pt_a is invalid and so
dereferencing pt_a->context causes a crash.
Yeah, I pushed my original fix. I intended to keep android userspace behavior the same, and I tried to keep the kernelspace the api same as much as I could. If peformance is the same, or not noticeably worse, would there be any objections on the android side about renaming dma-fence to syncpoint, and getting it in mainline?
~Maarten
linaro-mm-sig@lists.linaro.org
-
Maarten Lankhorst -
Rom Lemarchand