On Fri, Mar 14, 2025 at 10:02 PM feng.wei8@zte.com.cn wrote:

From: FengWei feng.wei8@zte.com.cn

Use max3() macro instead of nesting max() to simplify the return statement.

Signed-off-by: FengWei feng.wei8@zte.com.cn

The commit subject should include "dma-buf: heaps:" as a prefix.

With that: Reviewed-by: T.J. Mercier tjmercier@google.com

---

drivers/dma-buf/dma-heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 3cbe87d4a464..96cb9ab5731a 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -147,7 +147,7 @@ static long dma_heap_ioctl(struct file *file, unsigned int ucmd, in_size = 0; if ((ucmd & kcmd & IOC_OUT) == 0) out_size = 0;

•   ksize = max(max(in_size, out_size), drv_size);
  

•   ksize = max3(in_size, out_size, drv_size);
  
    /* If necessary, allocate buffer for ioctl argument */
    if (ksize > sizeof(stack_kdata)) {
  

-- 2.25.1