On 26/02/2026 14:40, Ioana Ciocoi-Radulescu wrote:
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/b...
- memory-region:
- description:
Phandle referencing a "shared-dma-pool" to be used for Neutroninference buffers, which need to be 1MB aligned.The memory region must be defined with alignment of 1MB and sizeshould be large enough to accommodate the targeted ML models. Itshould be marked as reusable.- maxItems: 1
- interrupts:
- maxItems: 1
- clocks:
- minItems: 2
- maxItems: 3
Why is this flexible?
- clock-names:
- minItems: 2
- items:
- const: npu
Name "npu" is pretty pointless.
- const: npu_apb- const: npu_cgc
Drop npu perfix everywhere.
- iommus:
- maxItems: 1
- power-domains:
- maxItems: 1
+required:
- compatible
- reg
- reg-names
- memory-region
- interrupts
+additionalProperties: false
+examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- #include <dt-bindings/interrupt-controller/irq.h>
- bus {
#address-cells = <2>;#size-cells = <2>;neutron@4ab00000 {compatible = "nxp,imx95-neutron";
Messed indentation. Read writing bindings / writing schema.
Best regards, Krzysztof
linaro-mm-sig@lists.linaro.org