Hi Lee,

...

Other public functions in radeon_device.c have their prototype in radeon.h - for example radeon_is_px()

Add radeon_device_is_virtual() there so we avoiid this new header.

Oh yes, I remember why this wasn't a suitable solution now:

The macro "radeon_init" in radeon.h clashes with the init function of the same name in radeon_drv.c:

In file included from drivers/gpu/drm/radeon/radeon_drv.c:53: drivers/gpu/drm/radeon/radeon_drv.c:620:31: error: expected identifier or ‘(’ before ‘void’ 620 | static int __init radeon_init(void)

...

How would you like me to move forward?

Fix the thousand of warnings in other places :-) I will take a look at radeon and post a new series based on your work with all W=1 warnings fixed.

Sam