arm_dma_limit stores physical address of maximal address accessible by DMA, so the phys_addr_t type makes much more sence for it instead of u32. This patch fixes the following build warning:
arch/arm/mm/init.c:380: warning: comparison of distinct pointer types lacks a cast
Reported-by: Russell King linux@arm.linux.org.uk Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com --- arch/arm/mm/init.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 8f5813b..39f2a86 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -211,7 +211,7 @@ EXPORT_SYMBOL(arm_dma_zone_size); * allocations. This must be the smallest DMA mask in the system, * so a successful GFP_DMA allocation will always satisfy this. */ -u32 arm_dma_limit; +phys_addr_t arm_dma_limit;
static void __init arm_adjust_dma_zone(unsigned long *size, unsigned long *hole, unsigned long dma_size)
On Wed, Jun 06, 2012 at 11:27:23AM +0200, Marek Szyprowski wrote:
arm_dma_limit stores physical address of maximal address accessible by DMA, so the phys_addr_t type makes much more sence for it instead of u32. This patch fixes the following build warning:
arch/arm/mm/init.c:380: warning: comparison of distinct pointer types lacks a cast
I assume this is not compile tested with CONFIG_ZONE_DMA=y, because:
arch/arm/mm/mm.h:extern u32 arm_dma_limit;
would also need to be fixed.
arm_dma_limit stores physical address of maximal address accessible by DMA, so the phys_addr_t type makes much more sense for it instead of u32. This patch fixes the following build warning:
arch/arm/mm/init.c:380: warning: comparison of distinct pointer types lacks a cast
Reported-by: Russell King linux@arm.linux.org.uk Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com --- arch/arm/mm/init.c | 2 +- arch/arm/mm/mm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index c21d06c..f54d592 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -212,7 +212,7 @@ EXPORT_SYMBOL(arm_dma_zone_size); * allocations. This must be the smallest DMA mask in the system, * so a successful GFP_DMA allocation will always satisfy this. */ -u32 arm_dma_limit; +phys_addr_t arm_dma_limit;
static void __init arm_adjust_dma_zone(unsigned long *size, unsigned long *hole, unsigned long dma_size) diff --git a/arch/arm/mm/mm.h b/arch/arm/mm/mm.h index 93dc0c1..c471436 100644 --- a/arch/arm/mm/mm.h +++ b/arch/arm/mm/mm.h @@ -62,7 +62,7 @@ extern void __flush_dcache_page(struct address_space *mapping, struct page *page #endif
#ifdef CONFIG_ZONE_DMA -extern u32 arm_dma_limit; +extern phys_addr_t arm_dma_limit; #else #define arm_dma_limit ((u32)~0) #endif
linaro-mm-sig@lists.linaro.org
-
Marek Szyprowski -
Russell King - ARM Linux