Hello,

On Wednesday, August 24, 2011 5:41 PM Aguirre, Sergio wrote:

On Fri, Aug 19, 2011 at 04:27:44PM +0200, Marek Szyprowski wrote:

...

This patch is an example how device private CMA area can be activated. It creates one CMA region and assigns it to the first s5p-fimc device on Samsung Goni S5PC110 board.

Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com

---

arch/arm/mach-s5pv210/mach-goni.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-

goni.c

...

index 14578f5..f766c45 100644 --- a/arch/arm/mach-s5pv210/mach-goni.c +++ b/arch/arm/mach-s5pv210/mach-goni.c @@ -26,6 +26,7 @@ #include <linux/input.h> #include <linux/gpio.h> #include <linux/interrupt.h> +#include <linux/dma-contiguous.h>

#include <asm/mach/arch.h> #include <asm/mach/map.h> @@ -857,6 +858,9 @@ static void __init goni_map_io(void) static void __init goni_reserve(void) { s5p_mfc_reserve_mem(0x43000000, 8 << 20, 0x51000000, 8 << 20);

• /* Create private 16MiB contiguous memory area for s5p-fimc.0 device */
• dma_declare_contiguous(&s5p_device_fimc0.dev, 16*SZ_1M, 0);

This is broken, since according to patch #0006, dma_declare_contiguous

requires

a 4th param (limit) which you're not providing here.

You are definitely right, there should be one more parameter. This patch was just cherry-picked from older version just before posting to mailing lists. I'm really sorry for this trivial bug.

Best regards