24.11.2021 19:40, Akhil R пишет:

...

24.11.2021 10:18, Akhil R пишет:

...

...

*i2c_dev)

...

          i2c_dev->is_vi = true;  }

How are you going to differentiate the VI I2C from a non-VI? This doesn't look right.

This patch adds the ACPI support to only non-VI I2C. The device_ids in match table are added accordingly. I suppose, of_device_is_compatible always returns false as there is no device tree. Agree with the other comments.

Will the VI I2C have a different ACPI ID or how it's going to work?

As there is a different compatible for VI I2C in device tree, I suppose the ACPI would have a different ID as well. I think the logic would also need an update if to have VI I2C using the ACPI. But that wasn't actually considered in this patch.

Thanks, you could reflected it in the commit message.