On Wed, Nov 19, 2025 at 03:53:30PM +0100, Christian König wrote:
<...>
+struct sg_table *dma_buf_map(struct dma_buf_attachment *attach,
That is clearly not a good name for this function. We already have overloaded the term *mapping* with something completely different.
This function performs DMA mapping, so what name do you suggest instead of dma_buf_map()?
Something like dma_buf_phys_vec_to_sg_table(). I'm not good at naming either.
Can I call it simply dma_buf_mapping() as I plan to put that function in dma_buf_mapping.c file per-your request.
No, just completely drop the term "mapping" here. This is about phys_vector to sg_table conversion and nothing else.
In order to progress, I renamed these functions to be dma_buf_phys_vec_to_sgt() and dma_buf_free_sgt(), and put everything in dma_buf_mapping.c file.
Thanks