14 Jan
2026
14 Jan
'26
12:04 p.m.
On Tue, 13 Jan 2026, Tomeu Vizoso tomeu@tomeuvizoso.net wrote:
+#include "linux/dev_printk.h"
Random drive-by comment, please use <> instead of "" for include/ headers.
+#include <drm/drm_file.h> +#include <drm/drm_gem.h> +#include <drm/drm_print.h> +#include <drm/thames_accel.h> +#include <linux/platform_device.h>
In general, I think it will make everyone's life easier in the long run if the include directives are grouped and sorted.
BR, Jani.
--
Jani Nikula, Intel