[Linaro-mm-sig] Re: [PATCH rc] RDMA: Handle the return code from dma_resv_wait_timeout() properly

On Tue, Aug 16, 2022 at 11:03:20AM -0300, Jason Gunthorpe wrote:

ib_umem_dmabuf_map_pages() returns 0 on success and -ERRNO on failure.

dma_resv_wait_timeout() uses a different scheme:

• Returns -ERESTARTSYS if interrupted, 0 if the wait timed out, or
• greater than zero on success.

This results in ib_umem_dmabuf_map_pages() being non-functional as a positive return will be understood to be an error by drivers.

Fixes: f30bceab16d1 ("RDMA: use dma_resv_wait() instead of extracting the fence") Cc: stable@kernel.org Tested-by: Maor Gottlieb maorg@nvidia.com Signed-off-by: Jason Gunthorpe jgg@nvidia.com

---

drivers/infiniband/core/umem_dmabuf.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)

Thanks, applied to -rc.