Re: [Linaro-mm-sig] [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops

On Mon, 20 Jun 2011 09:50:06 +0200, Marek Szyprowski m.szyprowski@samsung.com wrote:

+static inline void dma_sync_single_for_cpu(struct device *dev,

I wouldn't really put inline here or in the function below.

• dma_addr_t handle, size_t size, enum dma_data_direction dir)
  

+{

• BUG_ON(!valid_dma_direction(dir));
• debug_dma_sync_single_for_cpu(dev, handle, size, dir);
• if (!dmabounce_sync_for_cpu(dev, handle, size, dir))

• return;
  

• __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);

I know it is just copy'n'paste but how about:

if (dmabounce_sync_for_cpu(dev, handle, size, dir)) __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir);

+}

+static inline void dma_sync_single_for_device(struct device *dev,

• dma_addr_t handle, size_t size, enum dma_data_direction dir)
  

+{

• BUG_ON(!valid_dma_direction(dir));
• debug_dma_sync_single_for_device(dev, handle, size, dir);
• if (!dmabounce_sync_for_device(dev, handle, size, dir))

• return;
  

• __dma_single_cpu_to_dev(dma_to_virt(dev, handle), size, dir);

Same as above.

+}

/**

• dma_sync_single_range_for_cpu
• @dev: valid struct device pointer, or NULL for ISA and EISA-like

devices