On Tue, Feb 24, 2026 at 12:38:56AM +0530, Ekansh Gupta wrote: [..]
diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c new file mode 100644 index 000000000000..18b0d3fb1598 --- /dev/null +++ b/drivers/accel/qda/qda_drv.c @@ -0,0 +1,22 @@ +// SPDX-License-Identifier: GPL-2.0-only +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. +#include <linux/module.h> +#include <linux/kernel.h>
+static int __init qda_core_init(void) +{
- pr_info("QDA: driver initialization complete\n");
This print is useless as soon as you make the driver do anything, please don't include developmental debug logs.
In fact, this patch doesn't actually do anything, please squash things a bit to give it some meat.
Regards, Bjorn
- return 0;
+}
+static void __exit qda_core_exit(void) +{
- pr_info("QDA: driver exit complete\n");
+}
+module_init(qda_core_init); +module_exit(qda_core_exit);
+MODULE_AUTHOR("Qualcomm AI Infra Team"); +MODULE_DESCRIPTION("Qualcomm DSP Accelerator Driver"); +MODULE_LICENSE("GPL");
-- 2.34.1