On Mon, May 19, 2025 at 03:43:33PM GMT, Tomeu Vizoso wrote:
Add the bindings for the Neural Processing Unit IP from Rockchip.
v2:
- Adapt to new node structure (one node per core, each with its own IOMMU)
- Several misc. fixes from Sebastian Reichel
v3:
- Split register block in its constituent subblocks, and only require the ones that the kernel would ever use (Nicolas Frattaroli)
- Group supplies (Rob Herring)
- Explain the way in which the top core is special (Rob Herring)
v4:
- Change required node name to npu@ (Rob Herring and Krzysztof Kozlowski)
- Remove unneeded items: (Krzysztof Kozlowski)
- Fix use of minItems/maxItems (Krzysztof Kozlowski)
- Add reg-names to list of required properties (Krzysztof Kozlowski)
- Fix example (Krzysztof Kozlowski)
Signed-off-by: Tomeu Vizoso tomeu@tomeuvizoso.net Signed-off-by: Sebastian Reichel sebastian.reichel@collabora.com
This order of SoB is still odd. You as person sending it should be the last signing person. Are you sure you are using b4 for managing trailers? I would expect it to re-order these on every update and this is already v4.
.../bindings/npu/rockchip,rknn-core.yaml | 149 +++++++++++++++++++++
Filename matching compatible, so rockchip,rk3588-rknn-core.yaml
1 file changed, 149 insertions(+)
diff --git a/Documentation/devicetree/bindings/npu/rockchip,rknn-core.yaml b/Documentation/devicetree/bindings/npu/rockchip,rknn-core.yaml new file mode 100644 index 0000000000000000000000000000000000000000..fafd0b01da215c7396262012988e364ef07ea137 --- /dev/null +++ b/Documentation/devicetree/bindings/npu/rockchip,rknn-core.yaml @@ -0,0 +1,149 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/npu/rockchip,rknn-core.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Neural Processing Unit IP from Rockchip
+maintainers:
- Tomeu Vizoso tomeu@tomeuvizoso.net
+description:
- Rockchip IP for accelerating inference of neural networks, based on NVIDIA's
- open source NVDLA IP.
- There is to be a node per each core in the NPU. In Rockchip's design there
- will be one core that is special and needs to be powered on before any of the
- other cores can be used. This special core is called the top core and should
- have the compatible string that corresponds to top cores.
+properties:
- $nodename:
- pattern: '^npu@[a-f0-9]+$'
- compatible:
- oneOf:
Drop... if you followed my advice you would notice it is not necessary.
- enum:- rockchip,rk3588-rknn-core-top- enum:- rockchip,rk3588-rknn-core
My comments were only partially implemented. This syntax is really not readable and not necessary and I asked to make it part of previous enum. This is just one enum:
compatible: enum: - foo - bar
Best regards, Krzysztof