23 Sep
2025
23 Sep
'25
12:19 p.m.
On Tue, Sep 23, 2025 at 02:00:28PM +0200, Christian König wrote:
On 23.09.25 13:14, Dan Carpenter wrote:
Call dma_fence_put(fence) if dma_fence_add_callback() fails.
Well that change is obviously incorrect.
When dma_fence_add_callback() fails we already call dma_fence_put() and drop the reference.
When the dma_fence_add_callback() call succeeds the callback will drop the reference.
The problem here is that the return code of dma_fence_add_callback() is an integer error code instead of a bool and basically has the reverse meaning than what people usually expect.
Ah, yes. You're exactly correct of course. Sorry about that.
regards, dan carpenter