[Linaro-mm-sig] Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

On 19 4月 22 16:07:44, Christian König wrote:

Am 19.04.22 um 15:59 schrieb Cai Huoqing:

...

The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP which is integrated into NVIDIA Jetson AGX Xavier, so add driver support for this accelerator.

Signed-off-by: Cai Huoqing cai.huoqing@linux.dev

Well doesn't looks so bad on first glance (regarding coding style etc..)

But am I blind or isn't there any UAPI for the driver? I mean adding a DRM driver without any change to include/uapi/drm is really odd.

thanks for your reply, I will rename nvdla_ioctl.h which is UAPI headfile, then put it to include/uapi/drm.

thanks, Cai

Regards, Christian.