On Thu, Apr 09, 2020 at 06:50:30PM +0200, Peter Zijlstra wrote:
On Thu, Apr 09, 2020 at 09:08:26AM -0700, Minchan Kim wrote:
On Wed, Apr 08, 2020 at 01:59:08PM +0200, Christoph Hellwig wrote:
This allows to unexport map_vm_area and unmap_kernel_range, which are rather deep internal and should not be available to modules.
Even though I don't know how many usecase we have using zsmalloc as module(I heard only once by dumb reason), it could affect existing users. Thus, please include concrete explanation in the patch to justify when the complain occurs.
The justification is 'we can unexport functions that have no sane reason of being exported in the first place'.
The Changelog pretty much says that.
Okay, I hope there is no affected user since this patch. If there are someone, they need to provide sane reason why they want to have zsmalloc as module.
Acked-by: Minchan Kim minchan@kernel.org