Hi Christian König.


发件人: Xiang Gao <gxxa03070307@gmail.com>
发送时间: 2026年4月15日 13:41:01
收件人: sumit.semwal@linaro.org; christian.koenig@amd.com
抄送: linux-media@vger.kernel.org; dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org; linux-kernel@vger.kernel.org; 高翔
主题: [External Mail][PATCH] dma-buf: fix stale @lock references in struct dma_buf documentation
 
[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给misec@xiaomi.com进行反馈

From: Xiang Gao <gaoxiang17@xiaomi.com>

The kernel-doc comments for vmapping_counter and vmap_ptr in struct
dma_buf reference "@lock" as the protecting lock, but struct dma_buf
no longer has a "lock" member. The mutex was removed in favor of using
the dma_resv lock exclusively. The implementation correctly uses
dma_resv_assert_held(dmabuf->resv) in dma_buf_vmap() and
dma_buf_vunmap(), so update the documentation to reference @resv
instead.

Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>
---
 include/linux/dma-buf.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index 133b9e637b55..ef6d93fd7a2c 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -322,13 +322,13 @@ struct dma_buf {
         * @vmapping_counter:
         *
         * Used internally to refcnt the vmaps returned by dma_buf_vmap().
-        * Protected by @lock.
+        * Protected by @resv.
         */
        unsigned vmapping_counter;

        /**
         * @vmap_ptr:
-        * The current vmap ptr if @vmapping_counter > 0. Protected by @lock.
+        * The current vmap ptr if @vmapping_counter > 0. Protected by @resv.
         */
        struct iosys_map vmap_ptr;

--
2.34.1