Hi,
+struct dma_buf *virtgpu_gem_prime_export(struct drm_gem_object *obj,
int flags)+{
[ ... ]
+}
+struct drm_gem_object *virtgpu_gem_prime_import(struct drm_device *dev,
struct dma_buf *buf)+{
[ ... ]
+}
More code duplication.
diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h index 0c85914d9369..9c428ef03060 100644 --- a/include/uapi/linux/virtio_gpu.h +++ b/include/uapi/linux/virtio_gpu.h
API change should go to a separate patch.
+/*
- VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID
- */
+#define VIRTIO_GPU_F_CROSS_DEVICE 2
Hmm, how about VIRTIO_GPU_F_RESOURCE_UUID ?
@@ -87,6 +92,7 @@ enum virtio_gpu_ctrl_type { VIRTIO_GPU_RESP_OK_CAPSET_INFO, VIRTIO_GPU_RESP_OK_CAPSET, VIRTIO_GPU_RESP_OK_EDID,
- VIRTIO_GPU_RESP_OK_RESOURCE_ASSIGN_UUID,
The "assign" doesn't make sense in the reply. I'd name that VIRTIO_GPU_RESP_OK_RESOURCE_UUID or just VIRTIO_GPU_RESP_OK_UUID,
+/* VIRTIO_GPU_RESP_OK_RESOURCE_ASSIGN_UUID */ +struct virtio_gpu_resp_resource_assign_uuid {
- struct virtio_gpu_ctrl_hdr hdr;
- __u8 uuid[16];
+};
Same here.
cheers, Gerd