On Thu, Mar 26, 2026 at 2:15 AM Danilo Krummrich dakr@kernel.org wrote:
@Lyude, Alice, Miguel: Please have a look at what I came up with below.
Sounds fine to me, thanks!
- Regarding the enabled unstable feature: looks good -- it will go away this cycle anyway, so we may get a conflict, but that is fine.
- Regarding the `&raw`, that sounds also good. I see you did it similarly to how I did it for `bitmap.rs` -- thanks!
(And for future reference, the `bitmap.rs` one was 1.92 instead of 1.82 because that one was for unions, while this one is https://blog.rust-lang.org/2024/10/17/Rust-1.82.0/#safely-addressing-unsafe-...).
- Regarding the `expect(unused)` -- using `cfg_attr` is fine since it is a simple case, but if it becomes a big issue, then of course please feel free to use `allow` (you already know this, but in case it helps others: I wrote some considerations about this at https://docs.kernel.org/rust/coding-guidelines.html#lints).
Cheers, Miguel