On 6/28/22 23:12, Thomas Hellström (Intel) wrote:
Hi,
On 5/27/22 01:50, Dmitry Osipenko wrote:
Use ww_acquire_fini() in the error code paths. Otherwise lockdep thinks that lock is held when lock's memory is freed after the drm_gem_lock_reservations() error. The WW needs to be annotated as "freed"
s /WW/ww_acquire_context/ ? s /"freed"/"released"/ ?
, which fixes the noisy "WARNING: held lock freed!" splat of VirtIO-GPU driver with CONFIG_DEBUG_MUTEXES=y and enabled lockdep.
Cc: stable@vger.kernel.org
Can you dig up the commit in error and add a Fixes: Tag?
Using that and "dim fixes" will also make the Cc: stable tag a bit more verbose.
With that fixed,
Reviewed-by: Thomas Hellström thomas.hellstrom@linux.intel.com
I'll update this patch, thank you for taking a look.