On Sep 15, 2011 5:09 PM, "Clark, Rob" <rob@ti.com> wrote:
>
> On Thu, Sep 15, 2011 at 9:53 AM, Jordan Crouse <jcrouse@codeaurora.org> wrote:
> >
> > On 09/15/2011 03:31 AM, Sumit Semwal wrote:
> >>
> >> I forgot to mention: As per review comments from Hans, and others, the read
> >> / write ops are removed for now from both dma_buf_ops and fops of the
> >> associated file. Also mmap is made optional.
> >
> > My summary of the previous mail thread was that everybody ended up agreeing
> > that there is value in the read/write hooks.  I know I was convinced that
> > they could be useful.
>
>
> I guess it should be easier to add new APIs later, than take them away.. ;-)
>
> It seems like read/write could be potentially useful.. but couldn't
> think of any immediate need for them, so for me it seems ok to add
> later if/when needed.  If they are just optional dmabuf's, then no
> harm in adding more fxn ptrs to the struct later.

Although I do think read/write have immediate uses, I agree with Rob that they don't need to be part of this review.

> BR,
> -R
>
> >
> > Jordan
> >
> > _______________________________________________
> > Linaro-mm-sig mailing list
> > Linaro-mm-sig@lists.linaro.org
> > http://lists.linaro.org/mailman/listinfo/linaro-mm-sig
>
> _______________________________________________
> Linaro-mm-sig mailing list
> Linaro-mm-sig@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-mm-sig